fix: accept symbol feature flag keys#147
Open
dustinbyrne wants to merge 2 commits into
Open
Conversation
marandaneto
reviewed
May 12, 2026
| end | ||
|
|
||
| # @param [String] flag_key The unique flag key of the feature flag | ||
| # @param [String, Symbol] flag_key The unique flag key of the feature flag |
Member
There was a problem hiding this comment.
would that be a breaking change?
Contributor
Author
There was a problem hiding this comment.
No, it's additive. This is like a String | Symbol in TypeScript, so you can now optionally call using a symbol like:
get_feature_flag(:beta_flag)
dustinbyrne
force-pushed
the
fix/flag-symbol-keys
branch
from
c85b703 to
c9c3778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Feature flag APIs should accept Ruby symbols for flag keys as well as strings. Previously, symbol keys could miss local and remote flag lookups because SDK internals compared them directly against string keys.
This normalizes flag keys to strings across the flag APIs, including legacy single-flag methods, remote config payloads, and
evaluate_flags(flag_keys:).Review loop: checked the SDK diff against compatibility, API surface, entry-point tracing, performance, coverage, and error-handling criteria; no follow-up fixes were needed after the review.
💚 How did you test it?
bundle exec rspecbundle exec rubocop📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file