chore(rust): bump posthog-rs to 0.19.1#70107
Conversation
|
Reviews (1): Last reviewed commit: "chore(rust): bump posthog-rs to 0.19.1" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| mockall = "0.13.0" | ||
| moka = { version = "0.12.15", features = ["sync", "future"] } | ||
| posthog-rs = { version = "0.18.0", features = ["async-client", "capture-v1"] } | ||
| posthog-rs = { version = "0.19.1", features = ["async-client", "capture-v1"] } |
There was a problem hiding this comment.
posthog-rs 0.19.1 resolves with reqwest 0.13.4 while the workspace still pins reqwest 0.12.x. That makes Rust services using this dependency carry two separate reqwest/TLS stacks, which can increase binary size and connection-pool memory for PostHog delivery paths.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce41b9cbdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stacked on the 0.18.0 upgrade: 0.19.1 sends error tracking frames in canonical wire order (first SDK flip of the ordering standardization) and makes SDK-frame stripping robust to newer demangler renderings.
cat-ph
force-pushed
the
cat/bump-posthog-rs-0-19-1-on-67600
branch
from
ce41b9c to
ed1a92f
Compare
3 participants
Problem
posthog-rs 0.19.1 sends error tracking stack frames in canonical wire order (the first SDK flip of PostHog/sdk-specs#11) and carries the demangler-robust SDK-frame stripping fix. Bumping our own services onto it dogfoods the flip end to end: our rust exceptions arrive canonical, pass the cymbal version gate (cutoff 0.19.0), and keep grouping into their existing issues via the legacy fingerprint versions.
Stacked on #67600 (0.18.0 upgrade + on_error metric) — merge that first; this PR is just the 0.18.0 → 0.19.1 delta on top and retargets to master automatically when it lands.
Changes
capture_batch_immediate.How did you test this code?
Automated only:
cargo build/clippy -D warningsclean for the three consumers (common-posthog,batch-import-worker,cymbal).cargo test: batch-import-worker + common-posthog 687 passed total across the three consumers on top of the stacked branch, 0 failures — including eli's new on_error hook tests and the import worker'sfailure_reason_maps_every_variantmetric-contract test.Automatic notifications
Docs update
None — internal dependency bump.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code did the bump under my direction as part of the wire-order flip rollout: unified the split pins, caught the
capture_batchfire-and-forget semantics change (silent drops would have broken the import worker's loss accounting) and switched that call site to the immediate-delivery API introduced in posthog-rs #175.