Repository navigation
[Fix] dotnet worker latency - #757
Merged
Power-Maverick merged 2 commits intoOct 26, 2026
Merged
Conversation
Power-Maverick
approved these changes
Oct 26, 2026
Power-Maverick
merged commit Oct 26, 2026
22d0662
into
PowerPlatformToolBox:dev
8 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fingerprint of the dotnet worker was being recalculated multiple times on each message send and response received, adding significant latency. On a simple SQL 4 CDS query this was adding around 2 seconds to a query which would normally execute in around 0.2 seconds.
This change limits the fingerprint checks to the initial consent and process start points. Once the process has started and the RPC client is attached to its stdin/out streams, only basic checks are performed on each message to keep performance at a usable level.
Fixes #756
Type of change
Changes
In
workerBrokerManager.ts, split thecheck()method into two.check()preserves only the lightweight checks to ensure the tool is still alive and consent has not been revoked. The heavier checks for fingerprint validation are split intocheckSource()which is invoked only when consent is being granted and the tool process is being started.Architecture checklist
Packages (
types&validation)packages/Code quality
pnpm run typecheckpasses with 0 errors (warnings are acceptable)pnpm run lintpasses with 0 errors (warnings are acceptable)pnpm run buildcompletes successfullyTesting
pnpm run test:unitpasses (for changes tosrc/main/,src/common/, orsrc/renderer/utilities)pnpm run test:e2epasses (for UI / navigation / end-to-end flows)pnpm run dev)Scenario tested:
Breaking changes
Reviewer notes