Fix Locale in Metadata for New-MarkdownCommandHelp

[teramako]

PR Summary

use MetadataUtils.GetCommandHelpBaseMetadata(cmdHelp) instead of MetadataUtils.GetCommandHelpBaseMetadataFromCommandInfo(commandInfo)

PR Context

To fix issue:

• New-MarkdownCommandHelp doesn't respect -Locale #763

---

This change is 

[ArmaanMcleod]

Hey @adityapatwardhan Could we please review this PR?

[adityapatwardhan]

/azp run

[azure-pipelines]

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

[adityapatwardhan]

/azp run

[sdwheeler]

LGTM

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sdwheeler]

@adityapatwardhan LGTM

[teramako]

@adityapatwardhan
Rebased onto the latest main and resolved the merge conflict in the test file.
The previous CI failure was caused by the conflict, so please re-run the CI/CD pipeline.

[adityapatwardhan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adityapatwardhan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adityapatwardhan]

@teramako please have a look at the test failures

[teramako]

I reviewed the CI failure and confirmed that the regression comes from the
metadata changes introduced in this PR. The failing test output was:

Executing script D:\a\1\s\test\Pester\ConvertToCommandHelp.Tests.ps1

  Describing New-CommandHelp tests
    [+] Should return a command help object 12ms
    [+] Should have the appropriate metadata properties and values 'document type = cmdlet' 3ms
    [+] Should have the appropriate metadata properties and values 'title = New-CommandHelp' 2ms
    [+] Should have the appropriate metadata properties and values 'Module Name = microsoft.powershell.platyPS' 2ms
    [+] Should have the appropriate metadata properties and values 'Locale = en-US' 3ms
    [+] Should have the appropriate metadata properties and values 'PlatyPS schema version = 2024-05-01' 2ms
    [-] Should have the appropriate metadata properties and values 'HelpUri = <empty>' 21ms
      Expected <empty>, but got $null.
      26:         $result.Metadata[$key] | Should -Be $value
      at <ScriptBlock>, D:\a\1\s\test\Pester\ConvertToCommandHelp.Tests.ps1: line 26
    [+] Should have the appropriate metadata properties and values 'ms.date = 07/07/2026' 2ms
    [-] Should have the appropriate metadata properties and values 'external help file = Microsoft.PowerShell.PlatyPS.dll-Help.xml' 4ms
      Expected 'Microsoft.PowerShell.PlatyPS.dll-Help.xml', but got $null.
      26:         $result.Metadata[$key] | Should -Be $value
      at <ScriptBlock>, D:\a\1\s\test\Pester\ConvertToCommandHelp.Tests.ps1: line 26

Switching to MetadataUtils.GetCommandHelpBaseMetadata(cmdHelp) caused both
HelpUri and external help file to become $null, because CommandHelp
does not yet contain these values at the time metadata is generated. These
fields are only reliably populated when using
GetCommandHelpBaseMetadataFromCommandInfo(commandInfo).

Therefore, I am changing the approach: I will continue using
GetCommandHelpBaseMetadataFromCommandInfo(commandInfo) and update only the
Locale handling by passing the explicit locale value. This preserves the
existing behavior for HelpUri and external help file while still fixing the
Locale metadata issue.

A new commit has been pushed with this updated approach.

[adityapatwardhan]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[adityapatwardhan]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[sdwheeler]

LGTM