Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cornac/eval_methods/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from .base_method import BaseMethod
from .ratio_split import RatioSplit
from .stratified_split import StratifiedSplit
from .timestamp_split import TimestampSplit
from .cross_validation import CrossValidation
from .next_basket_evaluation import NextBasketEvaluation
from .next_item_evaluation import NextItemEvaluation
Expand All @@ -28,6 +29,7 @@
"BaseMethod",
"RatioSplit",
"StratifiedSplit",
"TimestampSplit",
"CrossValidation",
"NextBasketEvaluation",
"NextItemEvaluation",
Expand Down
131 changes: 131 additions & 0 deletions cornac/eval_methods/timestamp_split.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
# Copyright 2018 The Cornac Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ============================================================================

from .base_method import BaseMethod
from ..utils.common import safe_indexing


class TimestampSplit(BaseMethod):
"""Splitting data into training, validation, and test sets by absolute timestamp cutoffs.

Given two timestamps `val_timestamp` and `test_timestamp`, interactions are partitioned as:

train: timestamp < val_timestamp
validation: val_timestamp <= timestamp < test_timestamp
test: timestamp >= test_timestamp

Parameters
----------
data: array-like, required
Raw preference data in the quadruplet format [(user_id, item_id, rating_value, timestamp)].

val_timestamp: int or float, required
Cutoff between training and validation sets. Interactions with timestamp strictly
less than this value go into the training set.

test_timestamp: int or float, required
Cutoff between validation and test sets. Interactions with timestamp greater than
or equal to this value go into the test set. Must be greater than `val_timestamp`.

fmt: str, optional, default: 'UIRT'
Format of the input data. Must be 'UIRT' since timestamps are required.

rating_threshold: float, optional, default: 1.0
Threshold used to binarize rating values into positive or negative feedback for
model evaluation using ranking metrics (rating metrics are not affected).

seed: int, optional, default: None
Random seed for reproducibility.

exclude_unknowns: bool, optional, default: True
If `True`, unknown users and items will be ignored during model evaluation.

verbose: bool, optional, default: False
Output running log.

"""

def __init__(
self,
data,
val_timestamp,
test_timestamp,
fmt="UIRT",
rating_threshold=1.0,
seed=None,
exclude_unknowns=True,
Comment thread
qtuantruong marked this conversation as resolved.
verbose=False,
**kwargs
):
super().__init__(
data=data,
fmt=fmt,
rating_threshold=rating_threshold,
seed=seed,
exclude_unknowns=exclude_unknowns,
verbose=verbose,
**kwargs
)

if fmt != "UIRT" or len(self.data[0]) != 4:
raise ValueError(
'Input data must be in "UIRT" format for splitting by timestamp.'
)

if val_timestamp is None or test_timestamp is None:
raise ValueError(
"Both val_timestamp and test_timestamp are required."
)

if val_timestamp >= test_timestamp:
raise ValueError(
"val_timestamp ({}) must be strictly less than test_timestamp ({}).".format(
val_timestamp, test_timestamp
)
)

self.val_timestamp = val_timestamp
self.test_timestamp = test_timestamp

self._split()

def _split(self):
train_idx = []
val_idx = []
test_idx = []

for idx, row in enumerate(self.data):
ts = row[3]
if ts < self.val_timestamp:
train_idx.append(idx)
elif ts < self.test_timestamp:
val_idx.append(idx)
else:
test_idx.append(idx)

if len(train_idx) == 0:
raise ValueError(
"Training set is empty. val_timestamp may be too small."
)
if len(test_idx) == 0:
raise ValueError(
"Test set is empty. test_timestamp may be too large."
)

train_data = safe_indexing(self.data, train_idx)
test_data = safe_indexing(self.data, test_idx)
val_data = safe_indexing(self.data, val_idx) if len(val_idx) > 0 else None

self.build(train_data=train_data, test_data=test_data, val_data=val_data)
89 changes: 89 additions & 0 deletions tests/cornac/eval_methods/test_timestamp_split.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
# Copyright 2018 The Cornac Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ============================================================================

import unittest
import itertools
import random

from cornac.eval_methods import TimestampSplit


class TestTimestampSplit(unittest.TestCase):
def setUp(self):
random.seed(0)
users = ["u1", "u2", "u3", "u4", "u5", "u6"]
items = ["i1", "i2", "i3", "i4", "i5", "i6"]
pairs = list(itertools.product(users, items))
random.shuffle(pairs) # spread users/items across the timeline
self.data = [
(u, i, random.randint(1, 5), ts)
for ts, (u, i) in enumerate(pairs)
] # timestamps 0..35

def test_split(self):
eval_method = TimestampSplit(
self.data,
val_timestamp=12,
test_timestamp=24,
exclude_unknowns=False,
verbose=True,
)
self.assertEqual(eval_method.val_timestamp, 12)
self.assertEqual(eval_method.test_timestamp, 24)
self.assertEqual(eval_method.train_set.num_ratings, 12)
self.assertEqual(eval_method.val_set.num_ratings, 12)
self.assertEqual(eval_method.test_set.num_ratings, 12)

def test_empty_val(self):
# cutoffs land between integer timestamps, so val window contains no rows
eval_method = TimestampSplit(
self.data,
val_timestamp=11.5,
test_timestamp=11.6,
exclude_unknowns=False,
verbose=True,
)
self.assertEqual(eval_method.train_set.num_ratings, 12)
self.assertIsNone(eval_method.val_set)
self.assertEqual(eval_method.test_set.num_ratings, 24)

def test_requires_uirt(self):
uir_data = [(u, i, r) for (u, i, r, _) in self.data]
with self.assertRaises(ValueError):
TimestampSplit(uir_data, val_timestamp=12, test_timestamp=24, fmt="UIR")

def test_missing_cutoffs(self):
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=None, test_timestamp=24)
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=12, test_timestamp=None)

def test_invalid_order(self):
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=24, test_timestamp=12)
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=12, test_timestamp=12)

def test_empty_train(self):
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=0, test_timestamp=10)

def test_empty_test(self):
with self.assertRaises(ValueError):
TimestampSplit(self.data, val_timestamp=10, test_timestamp=100)


if __name__ == "__main__":
unittest.main()
Loading