fix: resolve merge conflict, eliminate hydration warnings, fix high-D…#1094
fix: resolve merge conflict, eliminate hydration warnings, fix high-D…#1094riyapetle wants to merge 2 commits into
Conversation
…PI rendering
**Summary of Changes:**
1. **Fixed Supabase Merge Conflict** (src/lib/supabase.ts)
- Resolved unresolved merge conflict with duplicate function definitions
- Removed git branch markers (fix-settings-api-500 and main branches)
- Kept clean implementation of getUserByUsername() and updateUserPublicFlag()
- Fixes critical build error
2. **Eliminated React Hydration Warnings** (5 components)
- Root cause: Third-party script injecting fdprocessedid attribute on buttons
- Applied suppressHydrationWarning to: KeyboardShortcuts, NotificationBell, ExportButton (CSV + PDF), WeeklySummaryCard, SignOutButton
- Console now clean of hydration mismatch warnings
3. **Fixed Missing React Key Props** (src/components/PRReviewTrendChart.tsx)
- Added key={dot-\} to custom dot renderer circles
- Eliminates React list reconciliation warning
4. **Refactored Language Indicators for High-DPI Displays** (src/components/LanguageBreakdown.tsx)
- Replaced fixed-pixel CSS dots (h-3 w-3 = 12px) with SVG vector implementation
- SVG automatically scales crisp at any DPI (1x, 2x Retina, 3x)
- Fixes blurry language indicator dots on high-DPI displays
**Testing:**
- Build completes successfully
- Dashboard loads without hydration warnings
- Language indicators render crisp on Retina displays
- All UI components functional
|
Someone is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
|
Merge conflict with main. Rebase to unblock: git fetch origin && git rebase origin/main
git push --force-with-lease |
|
This PR has merge conflicts with Resolve conflicts and force-push. |
Overview
This PR addresses critical build errors, React hydration warnings from third-party script interference, and visual rendering quality issues on high-DPI displays. All changes are minimal, focused, and maintain backward compatibility.
Changes Made
1. Fixed Supabase Merge Conflict (src/lib/supabase.ts)
getUserByUsername()andupdateUserPublicFlag()function definitions, kept single clean implementation2. Eliminated React Hydration Warnings (5 components)
fdprocessedidattribute on buttons at runtime, causing server render ≠ client render mismatchsuppressHydrationWarningattribute to affected button elementssrc/components/KeyboardShortcuts.tsx- collapse buttonsrc/components/NotificationBell.tsx- notification bell buttonsrc/components/ExportButton.tsx- CSV and PDF export buttons (2 buttons)src/components/WeeklySummaryCard.tsx- collapse toggle buttonsrc/components/SignOutButton.tsx- sign-out button<button suppressHydrationWarning {...otherProps} />3. Fixed Missing React Key Props (src/components/PRReviewTrendChart.tsx)
keypropkey={dot-${props.index}}to both null and valid data circle elements for proper list reconciliation4. Refactored Language Breakdown Indicators for High-DPI Displays (src/components/LanguageBreakdown.tsx)
h-3 w-3= 12px) that doesn't scale with device pixel ratio, appearing blurry on Retina/2x/3x DPI displaysLanguageDotcomponent that renders SVG:<svg viewBox="0 0 8 8"><circle cx="4" cy="4" r="4" fill={color} /></svg><span className="h-3 w-3 rounded-full" style={{backgroundColor}} /><LanguageDot color={color} label={label} />Files Modified
src/lib/supabase.ts- Merge conflict resolutionsrc/components/KeyboardShortcuts.tsx- Hydration warning fixsrc/components/NotificationBell.tsx- Hydration warning fixsrc/components/ExportButton.tsx- Hydration warning fix (2 buttons)src/components/WeeklySummaryCard.tsx- Hydration warning fixsrc/components/SignOutButton.tsx- Hydration warning fixsrc/components/PRReviewTrendChart.tsx- Missing key prop fixsrc/components/LanguageBreakdown.tsx- High-DPI SVG refactorTesting Checklist
Browser Console Output After Fix
✅ Clean console output (expected messages only):
/api/metrics/coding-time(WakaTime not configured - not a bug)