Skip to content

"Fix comment stripping regex removing URL content inside strings"#1112

Merged
Priyanshu-byte-coder merged 5 commits into
Priyanshu-byte-coder:mainfrom
namrarafique93-del:fix/comment-regex-url-handling
May 26, 2026
Merged

"Fix comment stripping regex removing URL content inside strings"#1112
Priyanshu-byte-coder merged 5 commits into
Priyanshu-byte-coder:mainfrom
namrarafique93-del:fix/comment-regex-url-handling

Conversation

@namrarafique93-del
Copy link
Copy Markdown
Contributor

Summary

Fixes an edge case where the single-line comment stripping regex could incorrectly remove URL content inside string literals.

Closes #1110

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / code cleanup

Changes Made

  • Improved single-line comment stripping regex
  • Prevented accidental removal of "//" inside URLs
  • Preserved existing import extraction behavior

How to Test

Steps for the reviewer to verify this works:

  1. Add a string containing a URL:

const url = "https://example.com";

  1. Run:

node scripts/check-missing-deps.js

  1. Verify the script still processes imports correctly without corrupting URL strings

Screenshots (if UI change)

N/A

Checklist

  • Linked issue in summary
  • "npm run lint" passes locally
  • No TypeScript errors ("npm run type-check")
  • Self-reviewed the diff
  • Added/updated tests if applicable

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

@namrarafique93-del is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the gssoc26 GSSoC 2026 contribution label May 25, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder Priyanshu-byte-coder added level:intermediate GSSoC: Intermediate difficulty (35 pts) gssoc:approved GSSoC: PR approved for scoring labels May 26, 2026
@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Playwright smoke tests are failing on this PR. Check the CI logs, fix failing tests, then push an update. Cannot merge while tests are red.

@github-actions github-actions Bot added the type:testing GSSoC type bonus: tests (+10 pts) label May 26, 2026
@namrarafique93-del
Copy link
Copy Markdown
Contributor Author

@Priyanshu-byte-coder Done please review again !!!

@Priyanshu-byte-coder Priyanshu-byte-coder merged commit c4663c2 into Priyanshu-byte-coder:main May 26, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

KrutagyaKaneria pushed a commit to KrutagyaKaneria/devtrack that referenced this pull request May 27, 2026
…iyanshu-byte-coder#1112)

* "Fix comment stripping regex removing URL content inside strings"

* fix: remove duplicate playwright test

* fix: resolve playwright footer selector issue
Ishta-P-Jain pushed a commit to Ishta-P-Jain/devtrack that referenced this pull request May 28, 2026
…iyanshu-byte-coder#1112)

* "Fix comment stripping regex removing URL content inside strings"

* fix: remove duplicate playwright test

* fix: resolve playwright footer selector issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:intermediate GSSoC: Intermediate difficulty (35 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Comment stripping regex incorrectly removes content inside strings

2 participants