Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ SCRIPT_MICROSERVICE_PUSHER_PORT=

# FrankenPHP workers ignore CLI php.ini. Use Caddyfile + --caddyfile=Caddyfile.
# OCTANE_MEMORY_LIMIT=512M
# OCTANE_MAX_EXECUTION_TIME=90
# OCTANE_MAX_EXECUTION_TIME=120
# OCTANE_POST_MAX_SIZE=200M
# OCTANE_UPLOAD_MAX_FILESIZE=200M
# OCTANE_MAX_INPUT_VARS=9000
Expand Down
4 changes: 2 additions & 2 deletions Caddyfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

frankenphp {
# FrankenPHP workers ignore CLI php.ini / PHPRC. Set PHP limits here.
php_ini memory_limit {$OCTANE_MEMORY_LIMIT:3072M}
php_ini max_execution_time {$OCTANE_MAX_EXECUTION_TIME:90}
php_ini memory_limit {$OCTANE_MEMORY_LIMIT:512M}
php_ini max_execution_time {$OCTANE_MAX_EXECUTION_TIME:120}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution time defaults disagree

Low Severity

Caddyfile and .env.example now default OCTANE_MAX_EXECUTION_TIME to 120, but config/octane.php still defaults both max_execution_time and caddy.env to 90. When Octane injects caddy.env, the 90 value wins and the intended timeout increase does not apply.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 494126e. Configure here.

php_ini post_max_size {$OCTANE_POST_MAX_SIZE:200M}
php_ini upload_max_filesize {$OCTANE_UPLOAD_MAX_FILESIZE:200M}
php_ini max_input_vars {$OCTANE_MAX_INPUT_VARS:9000}
Expand Down
3 changes: 2 additions & 1 deletion config/octane.php
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
// Services with mutable state that must be recreated per request
ProcessMaker\Managers\LoginManager::class,
ProcessMaker\Managers\ModelerManager::class,
ProcessMaker\Managers\ScreenBuilderManager::class,
Lavary\Menu\Menu::class,
],

Expand Down Expand Up @@ -254,7 +255,7 @@

'caddy' => [
'env' => [
'OCTANE_MEMORY_LIMIT' => env('OCTANE_MEMORY_LIMIT', '3072M'),
'OCTANE_MEMORY_LIMIT' => env('OCTANE_MEMORY_LIMIT', '512M'),
'OCTANE_MAX_EXECUTION_TIME' => env('OCTANE_MAX_EXECUTION_TIME', 90),
'OCTANE_POST_MAX_SIZE' => env('OCTANE_POST_MAX_SIZE', '200M'),
'OCTANE_UPLOAD_MAX_FILESIZE' => env('OCTANE_UPLOAD_MAX_FILESIZE', '200M'),
Expand Down
Loading