Fix client-trust issues in item usage, sell shops, and qbx medical sync - #31
Fix client-trust issues in item usage, sell shops, and qbx medical sync#31Brito1227 wants to merge 7 commits into
Conversation
Brito1227
commented
Jul 4, 2026
Brito1227
commented
- Replace client-triggered item usage handling with ox_inventory server-side usingItem post-hooks.
- Validate sell shop distance server-side before opening stashes and before paying item sales.
- Correct qbx_medical death state sync so died/revived events match isdead/inlaststand metadata.
|
Hey will try to check later this week, thanks for the contribution :D |
| itemsRegistry[itemName] = cb | ||
|
|
||
| if itemUseHooks[itemName] then | ||
| return | ||
| end |
There was a problem hiding this comment.
Before you do itemsRegistry[itemName] = cb just do if cb then return end no?
There was a problem hiding this comment.
I don't think that would work, since cb being valid doesn't mean the item is already registered. It would return for every valid callback and nothing would get registered.
I kept the hook check separate so the callback can still be updated without registering another hook.
| local item = bridge.inv.getSlot(src, slot) | ||
| if not item then return lib.print.debug("Item not found in slot:", slot) end | ||
| local function dispatchRegisteredItemUse(success, payload) | ||
| if not success or type(payload) ~= "table" or type(payload.item) ~= "table" then |
There was a problem hiding this comment.
Is there even a reason why payload or payload.item wouldnt be a table? I feel this checks are made in the inventory itself, no? I can confirm later.
There was a problem hiding this comment.
Yeah, you're right. I added those checks as a precaution in case the payload was ever unexpected, but since it comes directly from ox_inventory they should be unnecessary. I'll keep the success check though.
| itemsRegistry[itemName] = cb | ||
|
|
||
| if itemUseHooks[itemName] then | ||
| return | ||
| end |
|
Can you resolve conflict please? |
| return | ||
| end | ||
|
|
||
| local hookId = exports.ox_inventory:registerHook("usingItem", nil, { |
There was a problem hiding this comment.
You cant hardcode ox inventory. Theres nothing else or internal function? Like exports.qbx_core:CreateUseableItem or QBCore.Functions.CreateUseableItem
There was a problem hiding this comment.
ox_core doesn't provide an equivalent usable-item registration function, and there currently isn't an inventory-level adapter for this in prp-bridge. The qbx_core and QBCore functions are framework-specific, so they aren't available when using ox_core.
Would you prefer me to add a generic bridge.inv.registerItemUse function, implement the usingItem post-hook inside the ox_inventory adapter, and make the ox_core/nd_core modules delegate to the selected inventory?
2 participants
