Skip to content

feat(filelineedit): add browse button #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZnPdCo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(filelineedit): add browse button #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76f534
feat(filelineedit): add browse button
ZnPdCo Aug 21, 2026
faa78fa
fix(filelineedit): normalize file path
ZnPdCo Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions assets/pics/document-open.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions resource.qrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<file alias="deletecell.svg">assets/pics/deletecell.svg</file>
<file alias="document-close.svg">assets/pics/document-close.svg</file>
<file alias="document-export.svg">assets/pics/document-export.svg</file>
<file alias="document-open.svg">assets/pics/document-open.svg</file>
<file alias="document-new.svg">assets/pics/document-new.svg</file>
<file alias="document-save.svg">assets/pics/document-save.svg</file>
<file alias="globe.svg">assets/pics/globe.svg</file>
Expand Down
31 changes: 30 additions & 1 deletion src/filelineedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,17 @@
#include "filelineedit.h"
//
#include "base/settings.h"
//
#include <QAction>
#include <QFileDialog>
#include <QMessageBox>

FileLineEdit::FileLineEdit(QWidget *parent) : QLineEdit(parent) { completer = nullptr; }
FileLineEdit::FileLineEdit(QWidget *parent) : QLineEdit(parent) {
completer = nullptr;
QAction *browseAction = addAction(QIcon(":/icon/document-open.svg"), QLineEdit::TrailingPosition);

@CoelacanthusHex CoelacanthusHex Aug 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use QIcon::ThemeIcon::DocumentOpen instead.

browseAction->setToolTip(tr("Browse..."));
connect(browseAction, &QAction::triggered, this, &FileLineEdit::browse);
}

void FileLineEdit::getFiles(const QString &curDir, const QString &prefix, QStringList &files) {
QDir dir(curDir);
Expand Down Expand Up @@ -54,3 +63,23 @@ void FileLineEdit::refreshFileList() {
completer = new QCompleter(files, this);
setCompleter(completer);
}

void FileLineEdit::browse() {
QDir dataDir(QDir::currentPath());
dataDir.mkpath(Settings::dataPath());
dataDir.cd(Settings::dataPath());
QString filePath = QFileDialog::getOpenFileName(this, tr("Choose File"), dataDir.absolutePath());

if (filePath.isEmpty())
return;

QString relPath = dataDir.relativeFilePath(filePath);

if (relPath.startsWith("..") || QDir::isAbsolutePath(relPath)) {
QMessageBox::warning(this, tr("Warning"), tr("Please select a file inside the data directory."),
QMessageBox::Close);
return;
}

setText(QDir::toNativeSeparators(relPath));
}
1 change: 1 addition & 0 deletions src/filelineedit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class FileLineEdit : public QLineEdit {
QCompleter *completer;
QStringList nameFilters;
QDir::Filters filters;
void browse();

public slots:
void refreshFileList();
Expand Down
19 changes: 19 additions & 0 deletions translations/en_US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2694,4 +2694,23 @@ p, li { white-space: pre-wrap; }
<translation></translation>
</message>
</context>
<context>
<name>FileLineEdit</name>
<message>
<source>Browse...</source>
<translation></translation>
</message>
<message>
<source>Warning</source>
<translation></translation>
</message>
<message>
<source>Please select a file inside the data directory.</source>
<translation></translation>
</message>
<message>
<source>Choose File</source>
<translation></translation>
</message>
</context>
</TS>
19 changes: 19 additions & 0 deletions translations/zh_CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,4 +2728,23 @@ p, li { white-space: pre-wrap; }
<translation>新建</translation>
</message>
</context>
<context>
<name>FileLineEdit</name>
<message>
<source>Browse...</source>
<translation>浏览...</translation>
</message>
<message>
<source>Warning</source>
<translation>警告</translation>
</message>
<message>
<source>Please select a file inside the data directory.</source>
<translation>请选择 data 目录内的文件。</translation>
</message>
<message>
<source>Choose File</source>
<translation>选择文件</translation>
</message>
</context>
</TS>
19 changes: 19 additions & 0 deletions translations/zh_TW.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,4 +2728,23 @@ p, li { white-space: pre-wrap; }
<translation>新建</translation>
</message>
</context>
<context>
<name>FileLineEdit</name>
<message>
<source>Browse...</source>
<translation>瀏覽...</translation>
</message>
<message>
<source>Warning</source>
<translation>警告</translation>
</message>
<message>
<source>Please select a file inside the data directory.</source>
<translation>請選擇 data 目錄內的檔案。</translation>
</message>
<message>
<source>Choose File</source>
<translation>選擇檔案</translation>
</message>
</context>
</TS>