Skip to content

Propagate download publication failures #9177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdotc1 wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Propagate download publication failures #9177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ccfe93
Propagate failures before download publication completes
jdotc1 Oct 14, 2026
8b50ee6
DOC: Clarify download publication exceptions
jdotc1 Oct 16, 2026
d6edfb1
Merge dev and retain download exception documentation
jdotc1 Oct 16, 2026
7eded2e
Merge dev and retain download publication guard
jdotc1 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion monai/apps/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,12 @@ def download_url(
ContentTooShortError: See urllib.request.urlretrieve.
IOError: See urllib.request.urlretrieve.
HashCheckError: When the hash validation of the ``url`` downloaded file fails.
PermissionError: When access is denied before the downloaded file has been
moved to ``filepath``, including during destination setup or the move.
NotADirectoryError: When a path component is not a directory before the
downloaded file has been moved to ``filepath``. These filesystem
exceptions remain suppressed during temporary-directory cleanup after
a successful move.

.. versionchanged:: 1.7
The default `hash_type` changed from "md5" to None for stronger integrity verification. If this is left None
Expand All @@ -264,6 +270,7 @@ def download_url(
raise HashCheckError(f"{hash_type} hash check of existing file failed: {filepath=}, expected {hash_type=}.")
logger.info(f"File exists: {filepath}, skipped downloading.")
return
download_complete = False
try:
with tempfile.TemporaryDirectory() as tmp_dir:
tmp_name = Path(tmp_dir, _basename(filepath))
Expand Down Expand Up @@ -301,8 +308,11 @@ def download_url(
if file_dir:
os.makedirs(file_dir, exist_ok=True)
shutil.move(f"{tmp_name}", f"{filepath}") # copy the downloaded to a user-specified cache.
download_complete = True
except (PermissionError, NotADirectoryError): # project-monai/monai issue #3613 #3757 for windows
pass
# Retain only the historical post-publication cleanup exemption.
if not download_complete:
raise
Comment thread
coderabbitai[bot] marked this conversation as resolved.
logger.info(f"Downloaded: {filepath}")


Expand Down