feat(ci): build bindings for ARM linux#7652
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the main CI workflow to add a Linux ARM64 build variant that also builds the project’s language bindings, extending the existing “bindings” build pattern beyond x86_64.
Changes:
- Renames the Linux ARM64 release matrix entry to a “-bindings” variant.
- Enables
build_bindings: truefor the Linux ARM64 runner so Node and Python binding packaging steps run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
399
to
403
| - name: linux-arm64-release-bindings | ||
| build_bindings: true | ||
| continue-on-error: false | ||
| node: 24 | ||
| runs-on: ubuntu-24.04-arm |
Comment on lines
+399
to
+400
| - name: linux-arm64-release-bindings | ||
| build_bindings: true |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7652 +/- ##
==========================================
- Coverage 94.15% 90.75% -3.40%
==========================================
Files 484 484
Lines 37690 37690
==========================================
- Hits 35486 34206 -1280
- Misses 2204 3484 +1280 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nylinux The hard-coded -DVCPKG_TARGET_TRIPLET=x64-linux-release in CMAKE_ARGS forced vcpkg to look for an x86_64 compiler inside the aarch64 manylinux container, where none exists. Replace it with per-architecture overrides that set VCPKG_TARGET_TRIPLET as an environment variable (x64-linux-release for x86_64, arm64-linux-release for aarch64), which the vcpkg CMake toolchain reads. Also switch the linux-arm64-release-bindings runner from ubuntu-24.04-arm to ubuntu-26.04-arm to match the other Linux runners' baseline.
The base environment hard-codes x64-linux-release which forces vcpkg to look for an x86_64 compiler inside the aarch64 manylinux container, where none exists. Append a second CMAKE_ARGS via a cibuildwheel override for *-manylinux_aarch64 that shadows the triplet with arm64-linux-release. The x86_64 build is unchanged since the override selector does not match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #7651
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?