Develop tarun

README.md

@@ -100,7 +100,7 @@ sf provar auth login
 claude mcp add provar -s user -- sf provar mcp start --allowed-paths /path/to/your/provar/project
 ```
 
-📖 **[docs/mcp.md](https://github.com/ProvarTesting/provardx-cli/blob/main/docs/mcp.md) — full setup, all 42 tools, 6 resources, 11 MCP prompts, troubleshooting.**
+📖 **[docs/mcp.md](https://github.com/ProvarTesting/provardx-cli/blob/main/docs/mcp.md) — full setup, all 43 tools, 6 resources, 11 MCP prompts, troubleshooting.**
 
 ---
 
@@ -251,7 +251,7 @@ DESCRIPTION
   Note: --json is not available on this command — stdout is reserved for MCP traffic.
 
 TOOLS EXPOSED
-  42 tools across: project inspection & org describe, Page Object and test-case
+  43 tools across: project inspection & org describe, Page Object and test-case
   authoring/validation, test-suite/plan validation, properties files, Quality Hub
   (test runs, defects, corpus examples), Provar Automation, ANT build, and NitroX
   components. See docs/mcp.md for the full catalogue with schemas and examples.

scripts/mcp-smoke.cjs

@@ -191,6 +191,9 @@ async function runTests() {
       output_path: path.join(TMP, 'steps-required-smoke-rejected.testcase'),
     });
 
+  // ── 6c. provar_step_schema (by api_id) ────────────────────────────────────
+  if (inGroup('authoring')) await callTool('provar_step_schema', { api_id: 'UiConnect' });
+
   // ── 7. provar_testcase_validate ───────────────────────────────────────────
   if (inGroup('validation')) await callTool('provar_testcase_validate', { content: '<testCase/>' });
 

src/mcp/examples/bundledExamples.ts

@@ -0,0 +1,200 @@
+/*
+ * Copyright (c) 2024 Provar Limited.
+ * All rights reserved.
+ * Licensed under the BSD 3-Clause license.
+ * For full license text, see LICENSE.md file in the repo root or https://opensource.org/licenses/BSD-3-Clause
+ */
+
+/* eslint-disable camelcase */
+
+/**
+ * Offline, known-correct example test cases bundled with the MCP server.
+ *
+ * `provar_qualityhub_examples_retrieve` returns these (clearly labelled `bundled`)
+ * when no Provar API key is configured, so first-test-case generation in a brand-new
+ * project has *some* grounded XML to pattern-match against instead of falling back
+ * entirely to model recollection.
+ *
+ * Every example here is validated by test/unit/mcp/bundledExamples.test.ts, which runs
+ * it through the same best-practices + structural validators the server exposes and
+ * asserts quality_score === 100 with zero violations. If you add or edit an example,
+ * that test guards it against drifting out of correctness — it is what caught the
+ * original example using UiConnect / interaction=click / flat field assertions.
+ */
+
+export interface BundledExample {
+  id: string;
+  name: string;
+  /** Short scenario key used for lightweight query matching. */
+  scenario: string;
+  salesforce_object: string;
+  keywords: string[];
+  xml: string;
+}
+
+const UI_CREATE_VALIDATE_ACCOUNT = `<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<testCase guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e6f" id="1" registryId="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e60" name="Create and verify an Account via the Salesforce UI">
+  <summary>Creates an Account through the Salesforce UI (mandatory Name field), saves it, and verifies the Name on the record detail page.</summary>
+  <steps>
+    <apiCall apiId="com.provar.plugins.forcedotcom.core.testapis.ApexConnect" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e01" name="ApexConnect" testItemId="1" title="Salesforce Connect: MyConnection (Test)">
+      <arguments>
+        <argument id="connectionName"><value class="value" valueClass="string">MyConnection</value></argument>
+        <argument id="resultName"><value class="value" valueClass="string">MyConnection</value></argument>
+        <argument id="resultScope"><value class="value" valueClass="string">Test</value></argument>
+        <argument id="uiApplicationName"><value class="value" valueClass="string">LightningSales</value></argument>
+        <argument id="quickUiLogin"><value class="value" valueClass="boolean">true</value></argument>
+        <argument id="reuseConnectionName"/>
+        <argument id="webBrowser"/>
+      </arguments>
+    </apiCall>
+    <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiWithScreen" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e02" name="On Account Home screen" testItemId="2" title="On SF Account Home screen">
+      <arguments>
+        <argument id="uiConnectionName"><value class="value" valueClass="string">MyConnection</value></argument>
+        <argument id="target"><value class="uiTarget" uri="sf:ui:target?object=Account&amp;action=ObjectHome"/></argument>
+        <argument id="navigate"><value class="value" valueClass="string">Always</value></argument>
+        <argument id="targetDescription"><value class="value" valueClass="string">On SF Account Home screen</value></argument>
+        <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+        <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+      </arguments>
+      <clauses>
+        <clause name="substeps" testItemId="3">
+          <steps>
+            <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiDoAction" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e03" name="Click New" testItemId="4" title="Click the New button">
+              <arguments>
+                <argument id="locator"><value class="uiLocator" uri="ui:locator?name=New&amp;binding=sf%3Aui%3Abinding%3Aobject%3Fobject%3DAccount%26action%3DNew"/></argument>
+                <argument id="interaction"><value class="uiInteraction" uri="ui:interaction?name=action"/></argument>
+                <argument id="interactionDescription"><value class="value" valueClass="string">Click the New button</value></argument>
+                <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+                <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+              </arguments>
+            </apiCall>
+          </steps>
+        </clause>
+      </clauses>
+    </apiCall>
+    <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiWithScreen" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e04" name="On Account New screen" testItemId="5" title="On SF Account New screen">
+      <arguments>
+        <argument id="uiConnectionName"><value class="value" valueClass="string">MyConnection</value></argument>
+        <argument id="target"><value class="uiTarget" uri="sf:ui:target?object=Account&amp;action=New"/></argument>
+        <argument id="navigate"><value class="value" valueClass="string">Dont</value></argument>
+        <argument id="sfUiTargetResultName"><value class="value" valueClass="string">NewAccountId</value></argument>
+        <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+        <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+      </arguments>
+      <clauses>
+        <clause name="substeps" testItemId="6">
+          <steps>
+            <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiDoAction" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e05" name="Set Account Name" testItemId="7" title="Set the Account Name field">
+              <arguments>
+                <argument id="locator"><value class="uiLocator" uri="ui:locator?name=Name&amp;binding=sf%3Aui%3Abinding%3Aobject%3Fobject%3DAccount%26field%3DName"/></argument>
+                <argument id="interaction"><value class="uiInteraction" uri="ui:interaction?name=set"/></argument>
+                <argument id="interactionDescription"><value class="value" valueClass="string">Set the Account Name field</value></argument>
+                <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+                <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+                <argument id="value"><value class="value" valueClass="string">Provar Automation Account</value></argument>
+              </arguments>
+            </apiCall>
+            <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiDoAction" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e06" name="Click Save" testItemId="8" title="Click the Save button">
+              <arguments>
+                <argument id="locator"><value class="uiLocator" uri="ui:locator?name=save&amp;binding=sf%3Aui%3Abinding%3Aobject%3Fobject%3DAccount%26action%3Dsave"/></argument>
+                <argument id="interaction"><value class="uiInteraction" uri="ui:interaction?name=action"/></argument>
+                <argument id="interactionDescription"><value class="value" valueClass="string">Click the Save button</value></argument>
+                <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+                <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+              </arguments>
+            </apiCall>
+          </steps>
+        </clause>
+      </clauses>
+    </apiCall>
+    <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiWithScreen" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e07" name="On Account Detail screen" testItemId="9" title="On SF Account View screen">
+      <arguments>
+        <argument id="uiConnectionName"><value class="value" valueClass="string">MyConnection</value></argument>
+        <argument id="target"><value class="uiTarget" uri="sf:ui:target?object=Account&amp;action=View"/></argument>
+        <argument id="navigate"><value class="value" valueClass="string">Dont</value></argument>
+        <argument id="targetDescription"><value class="value" valueClass="string">On SF Account View screen</value></argument>
+        <argument id="captureBefore"><value class="value" valueClass="string">false</value></argument>
+        <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+        <argument id="sfUiTargetObjectId"><value class="variable"><path element="NewAccountId"/></value></argument>
+      </arguments>
+      <clauses>
+        <clause name="substeps" testItemId="10">
+          <steps>
+            <apiCall apiId="com.provar.plugins.forcedotcom.core.ui.UiAssert" guid="7c9e6a10-2b3c-4d5e-8f10-1a2b3c4d5e08" name="Verify Account Name" testItemId="11" title="Verify Account Name">
+              <arguments>
+                <argument id="fieldAssertions">
+                  <value class="valueList" mutable="Mutable">
+                    <uiFieldAssertion resultName="Name">
+                      <fieldLocator uri="ui:locator?name=Name&amp;binding=sf%3Aui%3Abinding%3Aobject%3Fobject%3DAccount%26field%3DName"/>
+                      <attributeAssertions>
+                        <uiAttributeAssertion attributeName="value" comparisonType="EqualTo">
+                          <value class="value" valueClass="string">Provar Automation Account</value>
+                        </uiAttributeAssertion>
+                      </attributeAssertions>
+                    </uiFieldAssertion>
+                  </value>
+                </argument>
+                <argument id="columnAssertions"><value class="valueList" mutable="Mutable"/></argument>
+                <argument id="pageAssertions"><value class="valueList" mutable="Mutable"/></argument>
+                <argument id="resultName"><value class="value" valueClass="string">AccountNameAssertion</value></argument>
+                <argument id="resultScope"><value class="value" valueClass="string">Test</value></argument>
+                <argument id="captureAfter"><value class="value" valueClass="string">false</value></argument>
+                <argument id="beforeWait"/>
+                <argument id="autoRetry"/>
+              </arguments>
+            </apiCall>
+          </steps>
+        </clause>
+      </clauses>
+    </apiCall>
+  </steps>
+</testCase>
+`;
+
+export const BUNDLED_EXAMPLES: BundledExample[] = [
+  {
+    id: 'bundled-ui-create-validate-account',
+    name: 'Create and verify an Account via the Salesforce UI',
+    scenario: 'ui-create-validate',
+    salesforce_object: 'Account',
+    keywords: ['ui', 'create', 'new', 'account', 'validate', 'verify', 'assert', 'save', 'record', 'detail'],
+    xml: UI_CREATE_VALIDATE_ACCOUNT,
+  },
+];
+
+export interface BundledExampleResult {
+  id: string;
+  name: string;
+  xml: string;
+  similarity_score: number;
+  salesforce_object: string;
+  quality_tier: string;
+  full_content: boolean;
+  source: 'bundled';
+}
+
+/**
+ * Pick up to `n` bundled examples for a query, ranked by keyword overlap. With a small
+ * bundled set this mostly returns everything, but it keeps the most on-topic example
+ * first. Returned objects mirror the corpus `CorpusExample` shape plus `source: 'bundled'`.
+ */
+export function selectBundledExamples(query: string, n?: number): BundledExampleResult[] {
+  const q = query.toLowerCase();
+  // Tolerate a missing/invalid n (callers that bypass the tool's zod default): return all.
+  const limit = typeof n === 'number' && Number.isFinite(n) && n > 0 ? Math.floor(n) : BUNDLED_EXAMPLES.length;
+  const scored = BUNDLED_EXAMPLES.map((ex) => {
+    const hits = ex.keywords.filter((k) => q.includes(k)).length;
+    return { ex, hits };
+  }).sort((a, b) => b.hits - a.hits);
+
+  return scored.slice(0, Math.max(1, limit)).map(({ ex, hits }) => ({
+    id: ex.id,
+    name: ex.name,
+    xml: ex.xml,
+    similarity_score: hits > 0 ? Math.min(1, 0.5 + hits * 0.05) : 0,
+    salesforce_object: ex.salesforce_object,
+    quality_tier: 'bundled',
+    full_content: true,
+    source: 'bundled',
+  }));
+}

src/mcp/rules/provar_best_practices_rules.json

@@ -2624,6 +2624,22 @@
       "notes": "Based on corpus analysis of 1451 test files with 329,424 <value> elements. Common AI hallucination: class='null' (never valid). Empty arguments should have no <value> child.",
       "source": "Corpus analysis: All valid value class patterns from InternalProjects"
     },
+    {
+      "id": "STEP-REQUIRED-ARGS-001",
+      "category": "StructureAndGrouping",
+      "name": "Steps must declare all schema-required arguments",
+      "description": "Every step type has a set of arguments Provar requires it to declare (even if empty). This rule derives that set for each apiId from provar_test_step_schema.json and flags any step missing one. It generalises the UiAssert-only UI-ASSERT-STRUCT-001 check to all step types (UiConnect, UiWithScreen, UiDoAction, UiFill, DB/Apex/REST steps, etc.), so a test case can no longer score 100 while omitting required arguments on non-UiAssert steps. Runs at major severity because the schema is a bundled reference, not the authoritative Quality Hub ruleset; UiAssert and the NitroX MS connect variants are excluded here as they have dedicated rules.",
+      "appliesTo": ["Step"],
+      "severity": "major",
+      "weight": 5,
+      "recommendation": "Add the missing argument(s) to the step. Arguments that carry no value should still be declared as empty self-closing tags (e.g. <argument id=\"beforeWait\"/>). See the provar://schema/test-step resource for each step type's required arguments.",
+      "check": {
+        "type": "schemaRequiredArguments",
+        "target": "step"
+      },
+      "notes": "Schema-driven: the required-argument list is read from provar_test_step_schema.json at runtime, so correcting the schema automatically corrects this rule. No per-argument list is hardcoded here.",
+      "source": "Derived from provar_test_step_schema.json (validated against docs/PROVAR_TEST_STEP_REFERENCE.md)"
+    },
     {
       "id": "UI-ASSERT-STRUCT-001",
       "category": "StructureAndGrouping",

src/mcp/rules/provar_layer1_rules.json

@@ -122,11 +122,29 @@
       "applies_to": "apiCall",
       "description": "UiDoAction interaction uses class=\"uiInteraction\"."
     },
+    {
+      "id": "UI-INTERACTION-002",
+      "severity": "ERROR",
+      "applies_to": "apiCall",
+      "description": "UiDoAction interaction name is a real Provar interaction (action/set/file), not a hallucination like click/type."
+    },
     {
       "id": "UI-ASSERT-STRUCTURE-001",
       "severity": "ERROR",
       "applies_to": "apiCall",
-      "description": "UiAssert uses nested field/column/page assertion containers, not a flat argument."
+      "description": "UiAssert field assertions use a nested <uiFieldAssertion>, not a flat argument or a <namedValues> block."
+    },
+    {
+      "id": "SF-CONNECT-TYPE-001",
+      "severity": "WARNING",
+      "applies_to": "testCase",
+      "description": "A Salesforce UI test connects via ApexConnect (API + UI), not a UiConnect with no ApexConnect."
+    },
+    {
+      "id": "CONNECT-REF-CONSISTENCY-001",
+      "severity": "WARNING",
+      "applies_to": "apiCall",
+      "description": "Every connection reference (uiConnectionName/apexConnectionName/…) matches a connect step's resultName."
     },
     {
       "id": "SETVALUES-STRUCTURE-001",