feat(graceful-shutdown): add preStopDelaySeconds before PROXYSQL PAUSE - #89
Open
Anton0C wants to merge 1 commit into
Open
feat(graceful-shutdown): add preStopDelaySeconds before PROXYSQL PAUSE#89Anton0C wants to merge 1 commit into
Anton0C wants to merge 1 commit into
Conversation
Without a delay, PROXYSQL PAUSE closes the MySQL listener immediately
while kube-proxy still routes new connections to the terminating pod:
Pod delete EndpointSlice update kube-proxy
───────── ────────────────── ──────────
t=0 PROXYSQL PAUSE ──► listener closed
t=0 (no new accepts) pod still in endpoints ──► still DNATs
to pod IP
│
▼
client connects ──► TCP ok ──► no MySQL greeting
(connect fails)
With preStopDelaySeconds:
t=0 sleep N pod still serving
t=N PROXYSQL PAUSE endpoints updated kube-proxy stops routing
(during sleep)
The delay is included in terminationGracePeriodSeconds alongside the
existing drain timeout.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hit this problem too, can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a delay, PROXYSQL PAUSE closes the MySQL listener immediately while kube-proxy still routes new connections to the terminating pod:
With preStopDelaySeconds:
The delay is included in terminationGracePeriodSeconds alongside the existing drain timeout.