Repository navigation
ci: harden the workflows to the shared template; release 10.0.1 [PRV-7340] - #70
Merged
Merged
Conversation
…7340] Bring CI and publish.yml up to the squiss-ts template: actions pinned to SHAs (Dependabot weekly, 7-day cooldown), permissions: {} with id-token: write only on the publish job, explicit secrets instead of secrets: inherit, persist-credentials: false, no cache in the publish job, pre-release skip and release-tag check, workflow_dispatch, and a zizmor CI job. Removes the debug step that expanded github.head_ref (a branch name an attacker controls) into a shell script. Patch release 10.0.1 proves the npm trusted publisher, now pointed at PruvoNet. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings CI and
publish.ymlup to the shared template (squiss-ts). zizmor before: 10 high, 4 medium; after: no findings.dependabot.ymlkeeps them current (weekly, 7-day cooldown).publish.yml:permissions: {},id-token: writeonly on the publish job, explicitSNYK_TOKEN/QLTY_COVERAGE_TOKENinstead ofsecrets: inherit,persist-credentials: false, no cache in the publish job, pre-release skip, release-tag check,workflow_dispatch. Removednpm install -g npm@latest(unpinned ad-hoc install; Node 24 ships npm 11.19) and the unneededgit fetch --unshallow.ci.yml: read-only permissions, declaredworkflow_callsecrets,persist-credentials: false, newWorkflow security (zizmor)job.10.0.1to prove the npm trusted publisher, which now points atPruvoNet/json-expression-eval. No code change.Tested locally (Node 24)
pnpm build+pnpm test:unit: 167 passed.After merge
Run
publish.yml→ verify10.0.1published by GitHub Actions with provenance.Ticket: PRV-7340.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.