Skip to content

Repository navigation

simplify handleStringAnnotation #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 1 commit into from
Sep 1, 2026
+3 −4
Merged

simplify handleStringAnnotation #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pyflakes/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,16 +1284,16 @@ def handleDoctests(self, node):
self.scopeStack = saved_stack

@in_string_annotation
def handleStringAnnotation(self, s, node, ref_lineno, ref_col_offset, err):
def handleStringAnnotation(self, s, node, ref_lineno, ref_col_offset):
try:
tree = ast.parse(s)
except SyntaxError:
self.report(err, node, s)
self.report(messages.ForwardAnnotationSyntaxError, node, s)
return

body = tree.body
if len(body) != 1 or not isinstance(body[0], ast.Expr):
self.report(err, node, s)
self.report(messages.ForwardAnnotationSyntaxError, node, s)
return

parsed_annotation = tree.body[0].value
Expand Down Expand Up @@ -1695,7 +1695,6 @@ def CONSTANT(self, node):
node,
node.lineno,
node.col_offset,
messages.ForwardAnnotationSyntaxError,
)
self.deferFunction(fn)

Expand Down
Loading