Repository navigation
Mirror pyscript-template's app from its root - #85
Merged
Merged
Conversation
The template moved its app from pwa/ to the repo root, so sync_assets skipped the mirror and the portal's copy froze. It now copies the root's app files, workers/ and the vendored PyScript, replacing the mirror whole so dropped files leave too. Without a vendored interpreter it leaves the mirror alone. Fixes #83.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyscript-template moved its app from
pwa/to the repo root, sosync_assets()found nothing to copy and the portal's/pyscript-template/pwa/froze at an old snapshot.sync_template_pwa()now copies the root's app files,workers/and the vendored PyScript (vendor/, fetched by the template'sscripts/vendor_pyscript.sh). It replaces the mirror whole so files the template drops leave the portal too, and it leaves the mirror alone if the interpreter hasn't been vendored rather than publish an app that can't start.Tested by running the sync into a portal checkout and loading the mirrored page in headless Chromium: Python loads, the display initialises, and the page shows its prompt. CI's idempotency job doesn't check out pyscript-template, so it skips this step as before.
Fixes #83.