Skip to content

Publishes pyo3-introspection as a wheel on Pypi#6018

Merged
Tpt merged 5 commits into
PyO3:mainfrom
Tpt:tpt/introspection-publish
May 13, 2026
Merged

Publishes pyo3-introspection as a wheel on Pypi#6018
Tpt merged 5 commits into
PyO3:mainfrom
Tpt:tpt/introspection-publish

Conversation

@Tpt
Copy link
Copy Markdown
Contributor

@Tpt Tpt commented May 7, 2026

No description provided.

@Tpt Tpt self-assigned this May 7, 2026
@Tpt Tpt added the CI-skip-changelog Skip checking changelog entry label May 7, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will improve performance by 28.28%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 29 improved benchmarks
✅ 96 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_class_attribute 16 µs 12.5 µs +27.74%
test_class_method 18.4 µs 15.5 µs +18.85%
test_empty_class_init 24.7 µs 15.8 µs +56.09%
test_empty_class_init_py 14.4 µs 10.9 µs +32.83%
test_getter 18.3 µs 15.1 µs +20.68%
test_method_call 17.3 µs 13.9 µs +24.35%
test_method_call_py 14.9 µs 10.9 µs +36.6%
test_proto_call 14 µs 10.4 µs +34.77%
test_proto_call_py 15.3 µs 11.7 µs +31.08%
test_setter 18.1 µs 14.7 µs +23.32%
test_static_method 17.6 µs 14.6 µs +20.61%
test_args_kwargs_py 18.6 µs 15 µs +24.37%
test_args_kwargs_rs 14.8 µs 11.1 µs +32.8%
test_many_keyword_arguments_py 19.3 µs 16.1 µs +20%
test_many_keyword_arguments_rs 20.2 µs 16.7 µs +21.46%
test_none_py 14.4 µs 10.3 µs +39.95%
test_none_rs 13.4 µs 9.7 µs +37.94%
test_positional_only_py 13.9 µs 10.2 µs +35.36%
test_positional_only_rs 14.4 µs 10.7 µs +34.08%
test_simple_args_kwargs_py 20.5 µs 17.1 µs +19.88%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Tpt:tpt/introspection-publish (c0b7938) with main (c92117c)

Open in CodSpeed

Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has warnings that the artifacts are not found to upload.

Comment thread .github/workflows/python-wheel.yml Outdated
@davidhewitt davidhewitt mentioned this pull request May 12, 2026
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a couple of the artifacts, they look good to me.

Brief question about the workflow_dispatch trigger, after that's figured out let's get this shipped in time for 0.29 🚀

Thank you for all your work on pyo3-introspection and experimental-inspect which has got us to this point!

on:
merge_group:
types: [ checks_requested ]
workflow_dispatch:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this copied from release.yml which also has workflow_dispatch event? I think having this can allow re-running the release if it fails, however maybe we should restrict it to tags to prevent accidental release on untagged stuff? (We might want to fix it on release.yml to only allow tags too?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pypi_release job is gated on tag push. So, it should not be possible to publish outside of a tag. I have relaxed a bit the constraint to also allow manual runs on tags: d328334

Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one tiny suggestion and then let's merge!

Comment thread .github/workflows/python-wheel.yml Outdated
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
@Tpt Tpt enabled auto-merge May 13, 2026 18:06
@Tpt Tpt added this pull request to the merge queue May 13, 2026
Merged via the queue into PyO3:main with commit 7cc707d May 13, 2026
46 of 48 checks passed
@Tpt Tpt deleted the tpt/introspection-publish branch May 13, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants