feat: Add spoiler channel flag and functions

[ToothyDev]

Summary

This adds ChannelFlags.is_spoiler_channel (following https://docs.discord.food/resources/channel#channel-flags) as well as a .spoiler property to all applicable channel types (all except category). Same goes for making it possible to create these channels via the regular channel creation methods, again with the exception of category channels. Channel editing with this flag is also functional.

Now that it's officially documented, here's the ddocs PR: discord/discord-api-docs#8465

Depends on discord/discord-api-docs#8465

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.
• AI Usage has been disclosed.
  • If AI has been used, I understand fully what the code does
• I have read the Contributing Guidelines

[pycord-app]

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3252/head:pr-3252
git checkout pr-3252

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3252/head

[Lulalaby]

take a shower <3

[Lulalaby]

took a shower apparently

[Lulalaby]

Can someone request changes reminding me to add editing & creating channels with that flag
and whatever else i may have forgotten

[Soheab]

Needs a way for bots to create this kind of channel

This message was sponsored by toothyfernsan on discord.

[ToothyDev]

I tested it with all but MediaChannels since I don't have access to those anywhere, but I'd still like a second pair of testing eyes on this

[ToothyDev]

Also, creating a channel with this turned on isn't possible unfortunately, gotta create + edit

[vmphase]

Good job.

[JustaSqu1d]

Inconsistency between notes and warnings for the documented behavior regarding NSFW and spoiler flag.

[vmphase]

LGTM from the technical side.

[Paillat-dev]

Thanks !

[vmphase]

Why does this PR add any kind of support for spoiler on StageChannel, while documentation explicitly says:

IS_SPOILER_CHANNEL ... Can be set on all textual guild channels and voice channels (not GUILD_STAGE).

[ToothyDev]

Why does this PR add any kind of support for spoiler on StageChannel, while documentation explicitly says:

IS_SPOILER_CHANNEL ... Can be set on all textual guild channels and voice channels (not GUILD_STAGE).

To stay internally consistent, because NSFW also doesn't work on stage channels, but Pycord supports it, it CAN be passed, it just has no effect. And actually, both toggles do exist (and work) in the client UI. Basically, everything works except it having an actual effect on the channel. So, while yes, it doesn't actually do anything, I still think it's worth keeping for internal consistency and because Discord might eventually make it work for stage channels (same for nsfw)

[vmphase]

Even though there is no technical difference, I would rather tend to making these ... for consistency with other overloads PEP 484 stub conventions..

[vmphase]

Same as in create_voice_channel overload.

[vmphase]

st has no effect. And actually, both toggles do exist (and work) in the client UI. Basically, everything works except it having an actual effect on the channel. So, while yes, it doesn't actually do anything, I still think it's worth keeping for internal consistency and because Discord might eventually make it work for stage channels (same for nsfw)

I see. If the development team is fine with this, sure.