Skip to content

fix(scheduled_events): decrement subscriber_count on user_remove - #3387

Merged
Lulalaby merged 2 commits into
masterfrom
fix/scheduled-event-subscriber-count
Sep 11, 2026
Merged

Lulalaby merged 2 commits into
masterfrom
fix/scheduled-event-subscriber-count

Conversation

@vmphase

@vmphase vmphase commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

This PR fixes a copy-paste bug from the user_add handler caused subscriber_count to increment when a user left a scheduled event (instead of decrement).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@vmphase
vmphase requested review from a team and VincentRPS September 11, 2026 11:20
@vmphase
vmphase requested a review from a team as a code owner September 11, 2026 11:20
@vmphase
vmphase requested review from Lulalaby and removed request for a team September 11, 2026 11:20
@pycord-app

pycord-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3387/head:pr-3387
git checkout pr-3387

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3387/head

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

@Lulalaby
Lulalaby merged commit f62473a into master Sep 11, 2026
25 checks passed
@Lulalaby
Lulalaby deleted the fix/scheduled-event-subscriber-count branch September 11, 2026 11:24
@github-project-automation github-project-automation Bot moved this from Todo to Done in Pycord Sep 11, 2026
@Paillat-dev

Copy link
Copy Markdown
Member

I think this code never runs or otherwise has some other issues. See PR by @Lumabots for the full fix

@Paillat-dev

Copy link
Copy Markdown
Member

#3025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants