Add partial type stubs for core modules - #95
Open
heejaechang wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hupper.interfaces,hupper.logger,hupper.polling, andhupper.utilspy.typedmarker in wheels and sdistsThis is intentionally partial.
hupper.watchdogremains unstubbed because its real platform-selectedwatchdog.observers.Observerbase is not a legal static base alias and its concrete external bases remain partially unknown under unfiltered VerifyTypes.ipc/worker/reloaderalso remain unstubbed because the Windows IPC surface publicly reexportshupper.winapi, including the real partially-unknownctypes.WinDLLobject. Hiding or replacing either boundary would misrepresent the runtime API.Type completeness
Exact unfiltered
pyright --verifytypes hupper --outputjson, without--ignoreexternal:The 13 added denominator symbols are real runtime reexports made explicit by the complete touched-module stubs; no exports were invented or hidden. Every touched export is known.
Validation
isattypython -m mypy.stubtestpasses all four modules in fresh wheels with watchdog installed and absentwatchdog.Observer, conditionalwinapi/ipc, and removeddistutils)pytest-covno longer providespytest_cov.embed.pyifiles pluspy.typed; runtime.pyhashes are unchangedLocal limitations: Python 3.7, 3.8, 3.10, 3.11, PyPy, and POSIX were unavailable. Pyright's Python 3.7 mode accepts the stubs; mypy 1.4.1 accepts the four stubs for Python 3.7. The docs tox environment matches clean main by failing only because POSIX
makeis unavailable on this Windows host.