docs(adapters): fix stale Codex and Cursor smoke commands in host matrix - #10
docs(adapters): fix stale Codex and Cursor smoke commands in host matrix#10creayma-del wants to merge 4 commits into
Conversation
The Host Adapter Matrix drifted from the shipped CLI. The Codex Smoke cell referenced a nonexistent `harness prepare --platform codex` command and an `html-report` validation step; the current chain is `harness analyze --platform codex` followed by a validated `harness render --mode html`. The Cursor Smoke cell claimed a working `agent --plugin-dir` -> evidence bundle -> validated render chain while roadmap records the Cursor runtime smoke as missing (open item U-04); it now names the correct cursor-agent binary and marks the smoke as not yet available instead of overstating support. This closes roadmap P0 item A-05. Default Output columns stay unchanged; the durable-HTML defaults are an accepted contract guarded by test/better-harness-skill.test.mjs. Story: roadmap.md TODO A-05 Spec: docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md Test: node --test test/agent-customize-architecture.test.mjs test/better-harness-skill.test.mjs test/doc-link-graph.test.mjs (19 pass)
phodal
left a comment
There was a problem hiding this comment.
The Story/Spec/commit chain is clear, the diff is focused, and validation is green: the declared focused command passes 19/19 locally, all four GitHub CI jobs pass 833/833 with package verification, the doc-link graph is current, and git diff --check passes.
Requesting changes for three documentation-contract blockers:
-
docs/adapters/README.md:22 claims a validated
harness render --mode htmlstep, but the renderer defaults validation to false and only runs validators with--validate. The new spec itself defines the correct chain asharness render --mode html --validate. Please include the flag explicitly. -
docs/adapters/README.md:24 still declares Cursor Default Output as self-contained HTML + Markdown, while roadmap.md says Harness analysis is No, Durable report is No supported pipeline, and U-03 is still open. A-05 says not to overstate Cursor output support. Please either mark output pending U-03, or establish the Cursor route with an explicit Cursor spec and executable evidence and then update the roadmap. A string assertion is not host/runtime proof.
-
docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md:27 and :63-64 incorrectly describe
agentas the wrong binary. The live official installer at https://cursor.com/install labelsagentas primary andcursor-agentas legacy; both point to the same 2026.07.23 executable, whose help usesUsage: agentand supports--plugin-dir. The missing contract is the real Better Harness Cursor host smoke, not the binary name. Please reword the spec and plan accordingly.
Please also complete the PR template Acceptance Criteria, Risk/Recovery, and AI Involvement fields. Risk and AI evidence are currently missing or unavailable and cannot be inferred from authorship or prose.
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复 Host Adapter Matrix(docs/adapters/README.md)中与当前已发布 CLI 不一致的烟测(smoke)命令描述,并在路线图中勾选已完成的 A-05,同时补充一份可追溯的规格说明(spec)来记录意图与验收标准。
Changes:
- 更新 Host Adapter Matrix:Codex smoke 命令改为
harness analyze --platform codex+ HTML 渲染链路;Cursor smoke 改为明确“尚不可用”,并指向路线图 U-04。 - 新增 A-05 对应 spec:记录 drift 背景、验收场景与测试证据。
- 路线图
roadmap.md将 A-05 标记为完成。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
roadmap.md |
将 P0 A-05 标记为已完成,以匹配本次文档修复的交付状态。 |
docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md |
新增 A-05 规格,描述问题来源、验收标准与测试证据。 |
docs/adapters/README.md |
修正 Codex/Cursor 的 smoke 描述,避免引用不存在或过度承诺的链路。 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolve the three CHANGES_REQUESTED blockers on PR QoderAI#10: - Codex Smoke cell now writes `harness render --mode html --validate` explicitly, since render-report.mjs defaults validate to false. - Cursor Default Output no longer claims a self-contained HTML + Markdown pipeline; it marks the durable-report output pending roadmap U-03, matching the roadmap "No supported pipeline" record. - Spec reworded so `agent`/`cursor-agent` are described as aliases for the same executable; the real missing contract is a Cursor host smoke (U-04), not the binary name. The guarding better-harness-skill test Cursor assertion is updated to the pending-U-03 marker; the Claude Code row assertion stays unchanged. Spec: docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md Test: node --test better-harness-skill agent-customize-architecture doc-link-graph legacy-product-names (20/20) AI: Assisted
Address the Copilot inline comment on PR QoderAI#10: the A-05 spec claimed the `html-report` validation step does not exist, but `html-report` is the real HTML validator check id defined in scripts/harness-analysis/renderers/html.mjs and asserted by test/harness-report-render-cli.test.mjs. Reword the Intent so only the `prepare` subcommand and a standalone `html-report` CLI step are called nonexistent, while validation runs through `harness render --mode html --validate`. Spec: docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md Test: node --test better-harness-skill doc-link-graph legacy-product-names (18/18) AI: Assisted
Resolve the docs/adapters/README.md matrix conflict introduced by the Qwen Code host adapter (QoderAI#6): keep this branch's reviewed Cursor row (Default Output pending U-03, runtime smoke pending U-04) and keep the new Qwen Code row, updating its Smoke cell from the nonexistent `harness prepare --platform qwen` -> `html-report` chain to the current `harness analyze --platform qwen` -> `harness render --mode html --validate` chain, matching A-05 AC-1 (no stale `harness prepare` / standalone `html-report` strings in the matrix; `--platform qwen` is accepted by scripts/harness-analysis/report-run.mjs). Test: node --test better-harness-skill agent-customize-architecture doc-link-graph legacy-product-names (21/21) AI: Assisted
The Host Adapter Matrix drifted from the shipped CLI. The Codex Smoke cell
referenced a nonexistent
harness prepare --platform codexsubcommand and astandalone
html-reportstep (html-reportis the HTML validator check idinside the renderer, not a CLI step); the current chain is
harness analyze --platform codexfollowed byharness render --mode html --validate, with the--validateflag writtenout because the renderer defaults validation to false.
The Cursor Smoke cell claimed a working
--plugin-dir-> evidence bundle ->validated render chain while roadmap tracks the packaged runtime smoke as open
item U-04; it now marks the smoke as not yet available. The binary name was
never the issue:
agentis the current primary Cursor CLI andcursor-agentis a legacy alias for the same executable.
The Cursor Default Output cell no longer claims a self-contained HTML +
Markdown pipeline; it marks the durable-report output as pending roadmap U-03,
matching the roadmap "No supported pipeline" record. The guarding
test/better-harness-skill.test.mjs Cursor assertion is updated to the
pending-U-03 marker; the Claude Code row assertion stays unchanged.
This closes roadmap P0 item A-05.
Story: roadmap.md TODO A-05
Spec: docs/specs/2026-07-28-a05-adapter-docs-stale-commands.md
Test: node --test test/agent-customize-architecture.test.mjs test/better-harness-skill.test.mjs test/doc-link-graph.test.mjs test/legacy-product-names.test.mjs (20 pass)
Summary
docs/adapters/README.mdsmoke and output cells now match the shipped CLI andthe roadmap: the Codex smoke chain uses existing commands with an explicit
--validate, and the Cursor row no longer overstates unshipped output orruntime smoke support (pending U-03 / U-04). Documentation-only plus one test
assertion update; no runtime behavior changes.
Why
Adapter Matrix no longer follow nonexistent commands (
harness prepare,standalone
html-report) or assume Cursor durable-report/runtime-smokesupport that the roadmap tracks as open.
Traceability and Scope
harness render --mode html --validate(render-report.mjs默认 validate=false);harness prepare、html-report已从 README 移除self-contained HTML + Markdown,标注待 roadmap U-03,与 roadmap "No supported pipeline" 一致test/agent-customize-architecture.test.mjs不变仍通过;test/better-harness-skill.test.mjs的 Cursor 断言同步为 pending-U-03 标记,Claude Code 行断言不变node --test test/doc-link-graph.test.mjs通过,无 markdown 链接变动Change Type
Test and Review Evidence
node --test test/better-harness-skill.test.mjs test/agent-customize-architecture.test.mjs test/doc-link-graph.test.mjs test/legacy-product-names.test.mjsnode --test test/better-harness-skill.test.mjs test/doc-link-graph.test.mjs test/legacy-product-names.test.mjs(after20b6578spec rewording)(roadmap U-03)Manual or visual evidence: grep confirmed
harness prepare/html-reportnolonger appear in
docs/adapters/README.md;self-contained HTML + Markdownremains only on the Claude Code and Codex rows.
Risk and Recovery
git revert <sha>即可完全回退AI Involvement
node --test跑通 better-harness-skill、agent-customize-architecture、doc-link-graph、legacy-product-names 共 20/20;并人工核对 README 单元格文本与测试正则逐字一致Checklist
AGENTS.md,CONTRIBUTING.md, and the relevant canonical-owner guidance.CHANGELOG.md.