Skip to content

feat(blueprints): add Blueprint-specific service settings - #2965

Draft
rmnbrd wants to merge 4 commits into
stagingfrom
feat/qov-2278-blueprint-specific-settings
Draft

rmnbrd wants to merge 4 commits into
stagingfrom
feat/qov-2278-blueprint-specific-settings

Conversation

@rmnbrd

@rmnbrd rmnbrd commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Implements QOV-2278 by giving Blueprint services a dedicated general settings page for manifest inputs instead of Terraform settings. Blueprint changes now require a preview confirmation before they are persisted and deployed, while regular Terraform services keep their existing settings.

  • Loads manifest fields from the Blueprint tag, validates required inputs, and preserves secret values.
  • Shows the preview in a non-dismissible modal with retry and return-to-configuration actions.
  • Adds tests for Blueprint settings, preview confirmation, modal behavior, and Terraform navigation.

Written for commit 9e821ab. Summary will update on new commits.

Review in cubic

@nx-cloud

nx-cloud Bot commented Sep 14, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9e821ab

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 17s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 24s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 44s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-15 16:06:20 UTC

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.73171% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.47%. Comparing base (526dae7) to head (9e821ab).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...nt-general-settings/blueprint-general-settings.tsx 70.93% 11 Missing and 14 partials ⚠️
libs/shared/ui/src/lib/components/modal/modal.tsx 27.27% 5 Missing and 3 partials ⚠️
...vice-general-settings/service-general-settings.tsx 0.00% 2 Missing ⚠️
...rint-update-flow/blueprint-update-preview-step.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2965      +/-   ##
===========================================
- Coverage    49.61%   49.47%   -0.15%     
===========================================
  Files         1356     1290      -66     
  Lines        29168    28089    -1079     
  Branches      8573     8321     -252     
===========================================
- Hits         14473    13896     -577     
+ Misses       12284    11880     -404     
+ Partials      2411     2313      -98     
Flag Coverage Δ
unittests 49.47% <70.73%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd
rmnbrd force-pushed the feat/qov-2278-blueprint-specific-settings branch from 410a004 to 4f5eeb0 Compare September 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant