Skip to content

feat(agent-task): add Qovery service context - #2966

Merged
RemiBonnet merged 38 commits into
stagingfrom
feat/agent-task-qovery-service-context
Sep 16, 2026
Merged

RemiBonnet merged 38 commits into
stagingfrom
feat/agent-task-qovery-service-context

Conversation

@RemiBonnet

@RemiBonnet RemiBonnet commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add a Qovery services context card to the Agent Task creation flow.
  • Let users select multiple services from the current environment.
  • Append selected service names, types, and IDs under Context services in the submitted agent prompt.
  • Exclude other Agent Tasks from the available context services.

Screenshots / Recordings

Screenshot 2026-09-15 at 11 10 12 Screenshot 2026-09-15 at 11 10 33 Screenshot 2026-09-15 at 11 10 48

Testing

  • Changes tested locally with focused component and request tests
  • yarn test (31 focused tests)
  • yarn prettier --check
  • yarn eslint
  • TypeScript typecheck

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Agent Tasks previously could not use Qovery services as context or enforce template MCP requirements. They now support both while preserving valid context and required MCP selections during configuration.

Details

  • Adds an Add context multi-select modal for services in the current environment, excluding other Agent Tasks.
  • Stores selected services in context_service_ids and replaces the delimited generated Context services prompt block with their names, types, and IDs.
  • Requires the read-only Qovery MCP for the incident.io, Honeybadger, and Build & deployment optimizer templates, reusing or creating it once, locked until ready, and preventing duplicate saves or submissions.
  • Preserves template query parameters, uppercases provider labels, renames the template request action, and upgrades qovery-typescript-axios to 1.1.976.

Written for commit 40f4f7f. Summary will update on new commits.

Review in cubic

Allow users to select services from the current environment and append their identifiers to the submitted agent prompt.
@nx-cloud

nx-cloud Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 28df3ee

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 12s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 33s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 47s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 8s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-15 15:14:37 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.90909% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.67%. Comparing base (c111726) to head (40f4f7f).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...settings/agentic-workflow-connections-settings.tsx 77.19% 4 Missing and 9 partials ⚠️
...w-configuration/agentic-workflow-configuration.tsx 84.33% 6 Missing and 7 partials ⚠️
...-services/use-agentic-workflow-context-services.ts 0.00% 4 Missing ⚠️
...-qovery-mcp-server/use-create-qovery-mcp-server.ts 0.00% 3 Missing ⚠️
...ic-workflow-settings/agentic-workflow-settings.tsx 76.92% 0 Missing and 3 partials ⚠️
...iguration/context/qovery-service-context-modal.tsx 86.36% 1 Missing and 2 partials ⚠️
...figuration/context/qovery-service-context-card.tsx 50.00% 2 Missing ⚠️
...w/agentic-workflow-configuration/mcp/mcp-sheet.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2966      +/-   ##
===========================================
+ Coverage    46.62%   50.67%   +4.04%     
===========================================
  Files          517     1338     +821     
  Lines        13628    28790   +15162     
  Branches      4221     8462    +4241     
===========================================
+ Hits          6354    14588    +8234     
- Misses        6203    11791    +5588     
- Partials      1071     2411    +1340     
Flag Coverage Δ
unittests 50.67% <80.90%> (+4.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Confidence score: 4/5

  • In qovery-service-context-modal.tsx, selecting every available service removes Select all without offering a clear-all action, forcing users to uncheck items individually; retain a Reset all or Clear all control for the editing flow.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-configuration/context/qovery-service-context-modal.tsx">

<violation number="1" location="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-configuration/context/qovery-service-context-modal.tsx:73">
P2: When every available service is selected, this modal now hides `Select all` and provides no clear-all action, so users must uncheck services one by one. Keep a `Reset all` or `Clear all` action for the editing flow.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 28 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 36 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 36 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 36 files (changes from recent commits).

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread libs/shared/ui/src/lib/components/modal/use-modal/use-modal.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 37 files (changes from recent commits).

Confidence score: 3/5

  • libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-request.ts can leave an edited service entry alongside a newly generated block when processing a legacy unmarked context, producing duplicate or incorrect workflow output; adjust replacement and edited-block detection ordering to preserve the edited entry correctly.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-request.ts">

<violation number="1" location="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-request.ts:37">
P2: When a legacy unmarked context block has an edited later service entry, this replacement strips only the generated prefix before edited-block detection runs. The edited entry then survives beside the newly generated block; replace the whole legacy section atomically or detect edited entries before removing its heading.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@Qovery Qovery deleted a comment from cubic-dev-ai Bot Sep 15, 2026
@Qovery Qovery deleted a comment from cubic-dev-ai Bot Sep 15, 2026
@Qovery Qovery deleted a comment from cubic-dev-ai Bot Sep 15, 2026
@Qovery Qovery deleted a comment from cubic-dev-ai Bot Sep 15, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 existing issue remains and no new issues found across 33 files (changes from recent commits).

Confidence score: 2/5

  • In libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-request.ts, replaceContextServicesInPrompt can consume and drop every subsequent nonblank line after an edited legacy context section, truncating the agent prompt and likely breaking workflow behavior—fix the matching logic and add coverage for a nonblank instruction following the edited section.

Requires human review: Auto-approval blocked because this review re-detected 2 unresolved issues already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 33 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread libs/shared/ui/src/lib/components/modal/use-modal/use-modal.tsx Outdated
<Navigate
to="/organization/$organizationId/project/$projectId/environment/$environmentId/service/create/agentic-workflow/configuration"
params={{ organizationId, projectId, environmentId }}
search={(search) => search}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to keep template URL

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 33 files (changes from recent commits).

Confidence score: 5/5

  • In git-context-card.tsx, configured-provider badges may show raw enum values such as GITHUB instead of user-friendly names like GitHub, creating a minor presentation regression; restore or reuse the PROVIDER_LABELS mapping.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-configuration/context/git-context-card.tsx">

<violation number="1" location="libs/domains/services/feature/src/lib/service-creation-flow/agentic-workflow/agentic-workflow-configuration/context/git-context-card.tsx:35">
P3: The badge label for a configured provider now renders the raw enum code ('GITHUB', 'GITLAB', 'BITBUCKET') instead of the previous friendly names ('GitHub', 'GitLab', 'Bitbucket'), because the PROVIDER_LABELS mapping was replaced with `provider.toUpperCase()`. If the uppercase mono look is intended, fine — but if the change was meant only to drop the mapping, keep the friendly labels and confirm the new casing matches the design.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment on lines +33 to 35
requiresQoveryMcp={selectedTemplate?.requiresQoveryMcp}
seed={selectedTemplate?.seed}
variablesSeed={selectedTemplate?.variables}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could pass the selectedTemplate altogether instead of having multiple props

@RemiBonnet
RemiBonnet merged commit 1dfcfcf into staging Sep 16, 2026
9 checks passed
@RemiBonnet
RemiBonnet deleted the feat/agent-task-qovery-service-context branch September 16, 2026 06:32
@RemiBonnet

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.354.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants