Skip to content

feat(agent-settings): manage LLM provider tokens - #2968

Merged
RemiBonnet merged 7 commits into
stagingfrom
feat/manage-agent-tokens
Sep 16, 2026
Merged

RemiBonnet merged 7 commits into
stagingfrom
feat/manage-agent-tokens

Conversation

@RemiBonnet

@RemiBonnet RemiBonnet commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Add personal and organization LLM provider token management to Settings > Agents
  • Support listing, creating, updating, rotating, and deleting Claude tokens

Screenshots / Recordings

Screenshot 2026-09-16 at 14 11 45 Screenshot 2026-09-16 at 14 59 38

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

Focused coverage:

  • Organization data-access suite: 11 tests passed
  • Agent settings and token modal suites: 9 tests passed

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Adds LLM provider token management in Settings > Agents and switches agent workflows from raw API keys to saved provider tokens, so stored credentials are never exposed.

  • Replaces the API key input in agent workflow settings and service creation with a saved-token selector; requests now send llm_provider_id instead of the key.
  • Splits the Agents settings page into separate Tokens and MCP pages, linked as singular "Token" and "MCP" items in the Settings menu.
  • Supports creating, editing, rotating, and deleting Claude tokens; blank edits preserve stored credentials and whitespace-only tokens are rejected.
  • Shows personal and organization tokens with configured status and ownership; only owners can manage personal tokens, and AWS Bedrock shows as disabled "Coming soon".
  • The service context modal always shows Unselect all, disabled when no services are selected.
  • Reads organization and environment ids from route params in agent workflow forms.
  • Labels the agentic workflow card as NEW instead of BETA on service creation.
  • Bumps qovery-typescript-axios to 1.1.979 for the LLM provider API contract.

Written for commit b0c35f5. Summary will update on new commits.

Review in cubic

@nx-cloud

nx-cloud Bot commented Sep 15, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit b0c35f5

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 12s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 8s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 39s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-16 12:57:13 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@RemiBonnet
RemiBonnet force-pushed the feat/manage-agent-tokens branch from 32e662f to 143f679 Compare September 16, 2026 11:24
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.59574% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.85%. Comparing base (9567451) to head (b0c35f5).

Files with missing lines Patch % Lines
...personalization/settings-agent-personalization.tsx 84.44% 5 Missing and 2 partials ⚠️
.../lib/llm-provider-setting/llm-provider-setting.tsx 71.42% 2 Missing and 2 partials ⚠️
...use-create-llm-provider/use-create-llm-provider.ts 0.00% 3 Missing ⚠️
...use-delete-llm-provider/use-delete-llm-provider.ts 0.00% 3 Missing ⚠️
...oks/use-edit-llm-provider/use-edit-llm-provider.ts 0.00% 3 Missing ⚠️
...eate-edit-modal/llm-provider-create-edit-modal.tsx 92.30% 2 Missing and 1 partial ⚠️
...ic-workflow-settings/agentic-workflow-settings.tsx 0.00% 2 Missing and 1 partial ⚠️
...c/lib/hooks/use-llm-providers/use-llm-providers.ts 0.00% 2 Missing ⚠️
...w-configuration/agentic-workflow-configuration.tsx 77.77% 2 Missing ⚠️
...w-configuration/agentic-workflow-prompt-editor.tsx 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2968      +/-   ##
===========================================
- Coverage    50.67%   49.85%   -0.83%     
===========================================
  Files         1339     1348       +9     
  Lines        28798    29098     +300     
  Branches      8466     8561      +95     
===========================================
- Hits         14594    14507      -87     
- Misses       11791    12206     +415     
+ Partials      2413     2385      -28     
Flag Coverage Δ
unittests 49.85% <76.59%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 💯

@RemiBonnet
RemiBonnet merged commit fbdac61 into staging Sep 16, 2026
10 of 11 checks passed
@RemiBonnet
RemiBonnet deleted the feat/manage-agent-tokens branch September 16, 2026 13:14
@RemiBonnet

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.355.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants