Skip to content

feat(agent): show flags for Bedrock regions and models - #3016

Merged
rmnbrd merged 4 commits into
stagingfrom
feat/bedrock-region-model-flags
Sep 25, 2026
Merged

rmnbrd merged 4 commits into
stagingfrom
feat/bedrock-region-model-flags

Conversation

@RemiBonnet

@RemiBonnet RemiBonnet commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

https://qovery.slack.com/archives/C0BEJ36TEJG/p1790323642802679

  • Show EU and US flags in the Amazon Bedrock AWS region selector.
  • Show flags beside Bedrock inference profiles based on each model ID, so mixed EU and US model lists remain easy to scan.
  • Reuse the existing IconFlag component and leave other model types unchanged.

Screenshots / Recordings

Screenshot 2026-09-25 at 11 07 50 Screenshot 2026-09-25 at 11 09 21

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

Focused verification completed:

  • Jest: model selector (11 tests), Bedrock token modal (8 tests), flag mapping (6 tests)
  • Prettier check and ESLint on changed files
  • TypeScript checks for the services and organizations feature libraries
  • git diff --check

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@nx-cloud

nx-cloud Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 844ea4a

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 4s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 46s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 39s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-25 09:15:00 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.84%. Comparing base (2e2dff1) to head (a7dca47).

Files with missing lines Patch % Lines
...eate-edit-modal/llm-provider-create-edit-modal.tsx 40.00% 0 Missing and 3 partials ⚠️
...gentic-workflow/agentic-workflow-model-setting.tsx 85.71% 0 Missing and 1 partial ⚠️
libs/shared/util-js/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3016      +/-   ##
===========================================
- Coverage    52.11%   50.84%   -1.27%     
===========================================
  Files         1280     1313      +33     
  Lines        28184    28937     +753     
  Branches      8554     8637      +83     
===========================================
+ Hits         14687    14713      +26     
- Misses       11071    11822     +751     
+ Partials      2426     2402      -24     
Flag Coverage Δ
unittests 50.84% <75.00%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd
rmnbrd merged commit 5322ea5 into staging Sep 25, 2026
11 of 12 checks passed
@rmnbrd
rmnbrd deleted the feat/bedrock-region-model-flags branch September 25, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants