Skip to content

feat(qov-2294): Handle ACCESS_DENIED audit log - #3018

Merged
mzottolaqovery merged 1 commit into
stagingfrom
qov-2294
Sep 25, 2026
Merged

mzottolaqovery merged 1 commit into
stagingfrom
qov-2294

Conversation

@mzottolaqovery

@mzottolaqovery mzottolaqovery commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Issue: https://qovery.atlassian.net/browse/QOV-2294

Handle Access Denied audit log type

Screenshots / Recordings

image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Marks ACCESS_DENIED audit log events as failed so they render with the red failure tag instead of appearing neutral.

  • Adds OrganizationEventType.ACCESS_DENIED to failed event detection alongside existing event types containing "fail".
  • Bumps qovery-typescript-axios to 1.1.988 to expose the new ACCESS_DENIED constant.
  • Adds test coverage for ACCESS_DENIED and POLICY_FAILED rendering as failed events.

Written for commit cd1c2d0. Summary will update on new commits.

Review in cubic

@mzottolaqovery mzottolaqovery changed the title feat(qov-2294) Handle DENIED_ACCESS audit log feat(qov-2294): Handle DENIED_ACCESS audit log Sep 25, 2026
@nx-cloud

nx-cloud Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit cd1c2d0

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 3s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded <1s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 57s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-25 12:16:39 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread package.json
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.99%. Comparing base (5322ea5) to head (cd1c2d0).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3018      +/-   ##
===========================================
+ Coverage    50.84%   50.99%   +0.14%     
===========================================
  Files         1313     1361      +48     
  Lines        28937    29747     +810     
  Branches      8637     8818     +181     
===========================================
+ Hits         14713    15169     +456     
- Misses       11822    12103     +281     
- Partials      2402     2475      +73     
Flag Coverage Δ
unittests 50.99% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mzottolaqovery mzottolaqovery changed the title feat(qov-2294): Handle DENIED_ACCESS audit log feat(qov-2294): Handle ACCESS_DENIED audit log Sep 25, 2026
@mzottolaqovery
mzottolaqovery merged commit d2f4e96 into staging Sep 25, 2026
12 checks passed
@mzottolaqovery
mzottolaqovery deleted the qov-2294 branch September 25, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants