Skip to content

feat(build-settings): move build settings into a dedicated page - #3019

Merged
killiancolla merged 5 commits into
stagingfrom
feat/QOV-2285/dedicated-buildsetting-page
Sep 25, 2026
Merged

killiancolla merged 5 commits into
stagingfrom
feat/QOV-2285/dedicated-buildsetting-page

Conversation

@killiancolla

@killiancolla killiancolla commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

Issue: QOV-2285

Add a new "Build settings" section in service settings for Application, Job, and Terraform services. Surfaces 6 build parameters (timeout, CPU, RAM, ephemeral storage, BuildKit cache, Git submodules) from the Advanced Settings table into a dedicated form with typed inputs.

Screenshots / Recordings

Before After
image image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Adds a dedicated Build settings page for Application, Job, and Terraform services, moving 6 build parameters (timeout, CPU, RAM, ephemeral storage, BuildKit cache, Git submodules) out of the Advanced Settings table into a typed form.

  • For Application, Job, and Terraform, the Advanced Settings table now hides build.* keys; Container services still show them.
  • Terraform services don't get the BuildKit cache toggle.
  • When build_settings_editable is false, all inputs are disabled and a callout with a "Contact support" button is shown.

Written for commit e8b3b6b. Summary will update on new commits.

Review in cubic

@nx-cloud

nx-cloud Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e8b3b6b

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 8s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 46s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 45s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 6s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-25 14:33:31 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.95%. Comparing base (5322ea5) to head (e8b3b6b).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../service-build-settings/service-build-settings.tsx 77.08% 3 Missing and 8 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3019      +/-   ##
===========================================
+ Coverage    50.84%   51.95%   +1.10%     
===========================================
  Files         1313     1359      +46     
  Lines        28937    29616     +679     
  Branches      8637     8773     +136     
===========================================
+ Hits         14713    15386     +673     
+ Misses       11822    11714     -108     
- Partials      2402     2516     +114     
Flag Coverage Δ
unittests 51.95% <80.70%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

name="disable_buildkit_cache"
control={control}
render={({ field }) => (
<InputToggle

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the small props please?

name="skip_git_submodules"
control={control}
render={({ field }) => (
<InputToggle

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the small props please?

@killiancolla
killiancolla merged commit 6cd4ead into staging Sep 25, 2026
9 checks passed
@killiancolla
killiancolla deleted the feat/QOV-2285/dedicated-buildsetting-page branch September 25, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants