fix(demo): support empty engine image overrides on macOS Bash - #700
Merged
Conversation
Avoid expanding an empty engine_image_overrides array under set -u, which causes qovery demo up to files on macOS’s Bash 3.2 with an “unbound variable” error. Add a regression test for the nounset-safe expansion.
Astach
approved these changes
Aug 28, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid expanding an empty engine_image_overrides array under set -u, which causes qovery demo up to files
on macOS’s Bash 3.2 with an “unbound variable” error. Add a regression test for the nounset-safe expansion.
Summary by cubic
Fixes
qovery demo upfailing on macOS's Bash 3.2 with an "unbound variable" error when no engine image overrides are set.Bug Fixes
engine_image_overridesarray using a Bash 3.2-safe form soset -uno longer aborts the script.Written for commit 8f48281. Summary will update on new commits.