fix: Bump qovery client to fix Ongoing service status issue - #701
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
go.modandgo.sum: the testify v1.12.1 content hash is missing fromgo.sum, which can cause dependency verification or test runs to fail for the many tests importing testify — regenerate or add the complete checksum entry before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="go.mod">
<violation number="1" location="go.mod:31">
P2: testify was bumped to v1.12.1 in go.mod, but go.sum was only given the `/go.mod` graph hash for that version (line 225) — the `h1:` content hash is missing (v1.11.1 had both). Because many `*_test.go` files import testify, `go test ./...` under the default `-mod=readonly` fails with a "missing go.sum entry ... to add it: go mod download github.com/stretchr/testify" error, blocking CI. Re-run `go mod download github.com/stretchr/testify` (or `go mod tidy`) so the v1.12.1 `h1:` hash is committed. Note the new qovery-client and yaml/v3 entries do have their `h1:` hashes; only testify's is incomplete.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| github.com/spf13/cobra v1.10.2 | ||
| github.com/spf13/pflag v1.0.10 | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/stretchr/testify v1.12.1 |
There was a problem hiding this comment.
P2: testify was bumped to v1.12.1 in go.mod, but go.sum was only given the /go.mod graph hash for that version (line 225) — the h1: content hash is missing (v1.11.1 had both). Because many *_test.go files import testify, go test ./... under the default -mod=readonly fails with a "missing go.sum entry ... to add it: go mod download github.com/stretchr/testify" error, blocking CI. Re-run go mod download github.com/stretchr/testify (or go mod tidy) so the v1.12.1 h1: hash is committed. Note the new qovery-client and yaml/v3 entries do have their h1: hashes; only testify's is incomplete.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At go.mod, line 31:
<comment>testify was bumped to v1.12.1 in go.mod, but go.sum was only given the `/go.mod` graph hash for that version (line 225) — the `h1:` content hash is missing (v1.11.1 had both). Because many `*_test.go` files import testify, `go test ./...` under the default `-mod=readonly` fails with a "missing go.sum entry ... to add it: go mod download github.com/stretchr/testify" error, blocking CI. Re-run `go mod download github.com/stretchr/testify` (or `go mod tidy`) so the v1.12.1 `h1:` hash is committed. Note the new qovery-client and yaml/v3 entries do have their `h1:` hashes; only testify's is incomplete.</comment>
<file context>
@@ -24,11 +24,11 @@ require (
github.com/spf13/cobra v1.10.2
github.com/spf13/pflag v1.0.10
- github.com/stretchr/testify v1.11.1
+ github.com/stretchr/testify v1.12.1
github.com/tonistiigi/go-rosetta v0.0.0-20220804170347-3f4430f2d346
github.com/xlab/treeprint v1.2.0
</file context>
b8d992d to
ad5f4b1
Compare
Summary by cubic
Bumps the
qovery-client-godependency to fix services incorrectly showing an Ongoing status. Also updatestestifyandyaml/v3to newer patch versions.Written for commit ad5f4b1. Summary will update on new commits.