test_pwt.csv.yml: record the true PWT 6.3 overlap — four POP and four XRAT values, not two - #103
Merged
Conversation
… XRAT values, not two The header's vintage-elimination trail said PWT 6.3 "matches Argentina and Australia POP but nothing else". Re-measured against the same archive (member sha256 f9609c42…), year 2000, exact float equality: 6.3 matches four of eight POP values (ARG, AUS, ISR, ZAF) and four of eight XRAT values, with no cc or cg value and no tcgdp column. The overlap is the hint any future vintage hunt would follow, so understating it is what this corrects. The adjacent 6.2/6.1 "match nothing" gets the same treatment from the same measurement: no POP, cc or cg value, with XRAT agreeing only on ARG+USA (6.2) and USA (6.1). The central conclusion stands as written — the committed values match no downloadable PWT vintage — and the four archive hashes were all re-derived and confirmed. Comment-only change: the parsed record, CATALOG.md and the strict audit are untouched. Found during the #100 validation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the provenance/vintage-elimination header comment in lectures/test_pwt.csv.yml to accurately record the measured overlap between the committed test_pwt.csv values and PWT 6.3/6.2/6.1 archives, without changing any parsed manifest fields or dataset bytes.
Changes:
- Refines the PWT 6.3 overlap statement from “two POP matches only” to “four POP + four XRAT exact matches, no cc/cg matches, no tcgdp column”.
- Refines the PWT 6.2/6.1 statement from “match nothing” to “no POP/cc/cg matches; limited XRAT agreement (ARG+USA in 6.2, USA in 6.1)”.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…atches Copilot review: the trailing 'exactly' could read as qualifying only XRAT, and the XRAT matches were not enumerated the way the POP ones are. The qualifier moves to the front of the pair, and the four 6.3 XRAT matches (ARG, MWI, USA, URY) are now recorded parallel to POP. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102.
The header's vintage-elimination trail understated the PWT 6.3 overlap: it said 6.3 "matches Argentina and Australia POP but nothing else", where the re-measurement (same archive, member sha256
f9609c42…, year 2000, exact float equality, python 3.12.13 / pandas 2.2.3 / xlrd 2.0.2) finds four of eight POP values (ARG, AUS, ISR, ZAF) and four of eight XRAT values matching exactly, with no cc or cg value and no tcgdp column. The overlap is exactly the hint a future vintage hunt would follow, which is why the precision matters even though the conclusion doesn't move.The adjacent 6.2/6.1 sentence gets the same treatment from the same measurement: "match nothing" becomes "match no POP, cc or cg value (XRAT agrees only on ARG+USA in 6.2 and USA in 6.1)".
The central negative claim stands as written — the committed values match no downloadable PWT vintage — and all four archive hashes in the header were re-derived and confirmed. Comment-only change: the parsed record is untouched,
CATALOG.mdregenerates with an empty diff, and YAML parses under both PyYAML and Psych.Found during the #100 validation (per-item report there, section 4.2).
🤖 Generated with Claude Code