Flip wave C1 to repointed — the three advanced.myst datasets (Track C) - #95
Merged
Conversation
lecture-python-advanced.myst#372 merged, so advanced.myst now reads all three files from this repo. This closes the red window that opens the moment a repoint lands: build_audit fails `--strict` on any dataset marked `landed` while a consumer already reads data-lectures, so main has been red since that merge. Measured in both directions rather than asserted, which is what makes this the wave's acceptance test rather than bookkeeping. Against post-merge main: `landed` gives exit 1 with three `migration_inconsistencies`, one per file; `repointed` gives exit 0 with all five problem buckets empty. The dry-run has to run against the consuming repo's post-merge main, because build_audit reads `origin/main` through git show and cannot see an unmerged branch. The three consumer notes come out. They were added in #92 to record that the lecture still read its own copies while the dataset sat at `landed` — that is now false, and a note claiming an unrepointed consumer would be exactly the kind of stale record #91 added them to prevent. CATALOG.md regenerates with those three warning markers gone; the three that remain are the unrelated ws#46 readers (caron.npy, nom_balances.npy, us_adult_heights.csv), which are genuinely still on local copies. Verified the edit touched nothing else: for each of the three manifests, the only top-level key differing from main is `consumers`, and `source.note`, `license.note` and `integrity.upstream.note` are byte-identical to main. That check is not decorative — the first attempt at this edit matched `integrity.upstream.note` instead, because both sit at the same indent, and silently deleted the provenance record. Anchor on the `consumers:` block. Ledger is now 36 datasets, all `repointed`, 0 `landed`. NOT done here, and the order matters: advanced.myst has not published since this repoint, so its published notebooks still carry the old URLs. The three local copies stay until it does. That is load-bearing for hansen_jagannathan_1991_data.json, which is fetched over the network at cell-execution time and therefore has no stale-serving grace period — its deletion breaks every published notebook and Colab reader the instant the blob leaves advanced.myst's main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the migration ledger to reflect that lecture-python-advanced.myst now consumes three Wave C1 datasets from QuantEcon/data-lectures, removing now-stale “reads local copy” notes and regenerating the auto-built catalog accordingly.
Changes:
- Flip three Wave C1 datasets in
migration.ymlfromlandedtorepointed, recording the repoint PR reference. - Remove temporary consumer
note:blocks from the three affected manifests now that the repoint has merged. - Regenerate
CATALOG.mdso the “local copy” warning markers are removed for these datasets.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
migration.yml |
Marks the three advanced.myst datasets as repointed and records the repoint PR in repoints. |
lectures/bbh_macro_quarterly.csv.yml |
Removes the no-longer-true consumer note about reading a local copy. |
lectures/bbh_michigan_monthly.csv.yml |
Removes the no-longer-true consumer note about reading a local copy. |
lectures/hansen_jagannathan_1991_data.json.yml |
Removes the no-longer-true consumer note about reading an own-repo raw URL. |
CATALOG.md |
Regenerated catalog reflecting the updated consumer notes (warning markers removed for these files). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
711
to
715
| # Wave C1 — the three lecture-python-advanced.myst datasets that needed no | ||
| # rename decision. `landed` here and NOT yet `repointed`: the lecture still | ||
| # reads its own copies, and the repoint PR follows this one (advanced.myst | ||
| # caches notebook execution, so the repointed cells re-execute against | ||
| # whatever is on this repo's main at that moment — data first, always). |
Open
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lecture-python-advanced.myst#372 merged, so advanced.myst now reads all three files from this repo. This closes a red window that is already open:
build_auditfails--stricton any dataset markedlandedwhile a consumer already reads data-lectures, somainhas been failing since that merge.The flip is the wave's acceptance test
Measured in both directions against post-merge
main, not asserted:landed(as main stands)repointed(this PR)The dry-run has to run against the consuming repo's post-merge main, because
build_auditreadsorigin/mainthroughgit showand cannot see an unmerged branch. That is why this could not have been validated before #372 landed.The three consumer notes come out
They were added in #92 to record that the lecture still read its own copies while the dataset sat at
landed. That is now false, and a note claiming an unrepointed consumer is exactly the stale record #91 introduced them to prevent.CATALOG.mdregenerates with those three warning markers gone.The three markers that remain are unrelated —
caron.npy,nom_balances.npyandus_adult_heights.csv, the QuantEcon/workspace-lectures#46 readers that are genuinely still on local copies.One check worth copying
For each manifest, the only top-level key differing from
mainisconsumers, andsource.note,license.noteandintegrity.upstream.noteare byte-identical to main.That assertion is not decorative. The first attempt at this edit anchored on
^ note: >and matchedintegrity.upstream.noteinstead — both sit at the same indent — silently deleting the provenance record while looking like it had worked. Anchor on theconsumers:block, and diff the parsed keys rather than eyeballing the patch.Not done here, and the order matters
advanced.myst has not published since the repoint, so its published notebooks still carry the old URLs. The three local copies stay there until it does.
That is load-bearing for
hansen_jagannathan_1991_data.json: it is fetched over the network at cell-execution time, so it has no stale-serving grace period — deleting it breaks every published notebook and Colab reader the instant the blob leaves advanced.myst'smain, rather than after a cache rebuild.Ledger is now 36 datasets, all
repointed.🤖 Generated with Claude Code