Skip to content

Fix two review-flagged defects and complete the 边际分布 glossary wave - #257

Merged
mmcky merged 2 commits into
mainfrom
review-riders-2026aug19
Aug 19, 2026
Merged

Fix two review-flagged defects and complete the 边际分布 glossary wave#257
mmcky merged 2 commits into
mainfrom
review-riders-2026aug19

Conversation

@mmcky

@mmcky mmcky commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Three small fixes left over from the 2026-08-19 backlog drain, none of which could be made on the branch that surfaced them.

Two defects the reviews flagged in pre-existing text

action-translation review mode caught both while reviewing sync PRs, but in each case the defective text pre-dated the PR under review, so it was out of scope for that branch and would have been lost when the PR merged.

lectures/inventory_q.md had an unclosed $t+1$ inline-math delimiter, which breaks rendering for the remainder of the line. The reviewer raised it as a blocker on the #217 review.

lectures/likelihood_ratio_process.md had a plot title rendering "nature" as 本质 (essence, character) where the rest of the document consistently uses 自然 for nature as the entity drawing samples. Raised on the #228 review.

The last two occurrences of 边际分布

This finishes the audit in #201. These two were deliberately held out of the main wave in #253 because sync PRs #241 and #247 still carried the rival term on their branches and would have reverted the fix. Both have now merged, so it is safe to land.

Both are the probability sense — the marginal distribution of each $k_i$ in multi_hyper, and the marginal distribution over employment/unemployment states in lake_model — which the glossary specifies as 边缘分布. The economics senses (边际产量, 边际消费倾向 and friends) keep 边际 and are untouched. The lake_model instance is the display text of a {ref} role; its target is unchanged.

After this the edition has zero occurrences of 边际分布 and is self-consistent on the term for the first time, so #201 can close when this merges.

Publishing note

The plot-title change is inside a code cell, so the next publish-* tag needs a cache.yml run before it reaches readers. That is true regardless of this PR — the 2026-08-19 drain merged code-cell changes across many lectures — but worth carrying on the ticket that touches one.

mmcky and others added 2 commits August 19, 2026 17:00
Both were caught by action-translation review mode during the
2026-08-19 backlog drain, in lecture text that pre-dated the PRs whose
reviews surfaced them, so neither could be fixed on its own branch.

- inventory_q.md: close the unclosed $t+1$ math delimiter. The
  reviewer flagged it as a blocker on the PR 217 review; unclosed
  inline math breaks rendering for the rest of the line.
- likelihood_ratio_process.md: a plot title translated "nature" as
  本质 (essence) where the rest of the document uses 自然 for nature
  as the entity drawing samples. Flagged on the PR 228 review.

The plot title is inside a code cell, so the next publish tag needs a
cache run before it reaches readers.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Finishes the audit in issue #201. These two were held back from the
main wave in PR #253 because sync PRs #241 and #247 still carried the
rival term on their branches; both have now merged, so the fix can
land without being reverted.

Both occurrences are the probability sense (the marginal distribution
of each $k_i$ in multi_hyper, and the marginal distribution over
employment states in lake_model), which the glossary specifies as
边缘分布. The economics senses keep 边际 and are untouched. The
lake_model instance is the display text of a {ref} role; its target is
unchanged.

The edition now has zero occurrences of 边际分布, and is for the first
time self-consistent on this term.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 19, 2026 07:00
@netlify

netlify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 4a2b06d
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/6a8554a3b6d7240008e8f348
😎 Deploy Preview https://deploy-preview-257--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up a small set of previously review-flagged translation/terminology defects and completes the glossary-driven standardization of “marginal distribution” as 边缘分布 across the zh-cn edition.

Changes:

  • Fixes an inline-math delimiter in inventory_q.md ($t+1$) to prevent broken rendering.
  • Updates a plot title in likelihood_ratio_process.md to use 自然 (consistent “nature” translation) instead of 本质.
  • Replaces the final two probability-sense occurrences of 边际分布 with 边缘分布 in multi_hyper.md and lake_model.md (verified: no remaining occurrences in-repo).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lectures/inventory_q.md Fixes inline math delimiter to restore correct Markdown/LaTeX rendering.
lectures/likelihood_ratio_process.md Adjusts plot title terminology to match document-wide “nature” translation.
lectures/multi_hyper.md Updates probability terminology to glossary-correct 边缘分布 for each (k_i).
lectures/lake_model.md Updates {ref} display text to 边缘分布 for employment/unemployment state distribution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

@mmcky
mmcky merged commit 1965827 into main Aug 19, 2026
8 checks passed
@mmcky
mmcky deleted the review-riders-2026aug19 branch August 19, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants