Remove the stale duplicated frontmatter block from hoist_failure.md - #265
Open
mmcky wants to merge 1 commit into
Open
Remove the stale duplicated frontmatter block from hoist_failure.md#265mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
The #260 resync left the previous frontmatter body in place below the new frontmatter, as text ahead of the {raw} header. Sphinx then reports 'Document headings start at H2, not H1' and the strict -W cache build fails (run 32426519586), which blocks the next publish tag. Only the duplicated block is removed; the engine's frontmatter and the lecture body are unchanged.
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a strict-build Sphinx warning in lectures/hoist_failure.md by removing a stale, duplicated frontmatter block left behind by an earlier resync, ensuring the document’s H1 heading is correctly recognized.
Changes:
- Removed the duplicated embedded frontmatter (
jupytext:/kernelspec:/translation:…---) that appeared after the real YAML frontmatter. - Restored the intended document structure so the
{raw}header and#H1 are no longer preceded by stray frontmatter content.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict cache build (run 32426519586) executed every notebook — including
learning_approximationafter #262 — and then failed on a single-Wwarning:hoist_failure.md:34: Document headings start at H2, not H1.Cause: the #260 resync left the previous frontmatter body in place below the new frontmatter (lines 32–58 on
main: a barejupytext:…translation:block closed by---), so Sphinx sees leading content ahead of the{raw}header and the H1. The preview build on #260 tolerated it as a warning, which is the same preview-vs-strict-build gap that let the_fonts/path through.This removes only the duplicated 25-line block; the engine's frontmatter (which carries the fuller nested heading map) and the lecture body are untouched. Once merged, a cache run should go green and the publish tag can follow with
mccall_risk(#264) included.This is a second instance of an engine resync shipping an embedded-frontmatter defect; noted for QuantEcon/action-translation (the
forwardpath has an embedded-frontmatter check, so the question is why it did not fire here).