Cut the dashboard caveat down to a footnote - #249
Merged
Conversation
The explanatory note added alongside the sessions relabel took the top of the page, above the charts people come for. The substance is worth keeping -- these are visits rather than people, and the total spans eight lecture series -- but it does not warrant two paragraphs of prime position. Reduced to a single line below the charts, in smaller muted type above a rule. Keeps the caveat recorded next to the chart, which is what QuantEcon/website-dynamic#9 asked for, without leading with it. No change to the data the page reads or renders.
✅ Deploy Preview for grand-swan-ca5201 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the QuantEcon analytics dashboard page to keep the “sessions vs people” caveat recorded near the charts while reducing its visual prominence.
Changes:
- Removes the multi-paragraph explanatory note previously shown above the charts.
- Adds a single-line footnote placed below the charts.
- Updates styling by replacing the old note styles with a new “footnote” style.
Comment on lines
+50
to
+55
| .dashboard-footnote { | ||
| max-width: 800px; | ||
| margin: 0 auto 3rem auto; | ||
| color: #5a6472; | ||
| font-size: 0.95rem; | ||
| line-height: 1.6; | ||
| } | ||
|
|
||
| .dashboard-note p { | ||
| margin: 0 0 0.75rem 0; | ||
| } | ||
|
|
||
| .dashboard-note p:last-child { | ||
| margin-bottom: 0; | ||
| margin: 3rem auto 0 auto; | ||
| padding-top: 1rem; | ||
| border-top: 1px solid #e0e0e0; | ||
| color: #7a828d; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #248, at @mmcky's suggestion.
The explanatory note that came with the sessions relabel sat above the charts and ran to two paragraphs. The substance is worth keeping — these are visits rather than people, and the total spans eight lecture series — but it does not need the top of the page, above the charts people arrive for.
This cuts it to a single line below the charts, in smaller muted type above a horizontal rule:
That keeps the caveat recorded next to the chart, which is what QuantEcon/website-dynamic#9 asked for, without leading with it.
Dropped from the longer version: the explanation of why sessions rather than users are reported — that user counts cannot be summed across properties because GA4 offers no cross-property deduplication. That reasoning is recorded in QuantEcon/website-dynamic#9 and will be covered in the pipeline documentation under QuantEcon/website-dynamic#16, so it is not lost, just not on the page.
No change to the data the page reads or renders — the field reads are untouched and verified identical.
Happy to remove the footnote entirely instead if you would rather have nothing there; I kept a minimal version because #9's "done when" asked for the caveat to be stated next to the chart rather than left implicit.
🤖 Generated with Claude Code