Skip to content

chore(deps): align QPK pin to 31892425a022 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 10, 2026
Merged

chore(deps): align QPK pin to 31892425a022 #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.1.0"
description = "QuantStrategyLab platform layer for Binance exchange."
requires-python = ">=3.11"
dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@56a03364d517fd0e2efb2c4d4add8a785fc5e857",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@31892425a02242126265ac07a626d98796daa459",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the QPK pin enforced by CI

In the checked .github/workflows/ci.yml step at lines 92-102, CI downloads QuantPlatformKit/main/QPK_PIN and passes it to check_qpk_pin_consistency.py; as of July 10, 2026 that upstream pin is still 56a03364d517fd0e2efb2c4d4add8a785fc5e857, so changing this repo to 31892425a022... makes every CI run report pyproject/uv.lock QPK mismatches. Unless the upstream QPK_PIN on main is updated first, or this workflow is changed to read the same QPK ref being reviewed, this pin bump cannot pass the required guard.

Useful? React with 👍 / 👎.

"crypto-strategies @ git+https://github.com/QuantStrategyLab/CryptoStrategies.git@ef78312d7653095f585c4f75d45bf765bedc2751",
"python-binance",
"pandas",
Expand All @@ -23,7 +23,7 @@ test = [

[tool.uv]
override-dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@56a03364d517fd0e2efb2c4d4add8a785fc5e857",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@31892425a02242126265ac07a626d98796daa459",
]

[tool.ruff]
Expand Down
2 changes: 1 addition & 1 deletion qsl.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ expires_at = "2026-09-30"
next_action = "keep uv.lock current and maintain QPK/CryptoStrategies pin consistency"

[qsl.requires]
quant_platform_kit = "56a03364d517fd0e2efb2c4d4add8a785fc5e857"
quant_platform_kit = "31892425a02242126265ac07a626d98796daa459"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align CryptoStrategies with the QPK bundle

With enforce_bundle = true, bumping this repo to QPK 31892425... should also move the companion CryptoStrategies pin to the QSL pin set for that rollout, but this commit leaves every crypto-strategies reference at ef78312... (pyproject.toml, qsl.toml, and uv.lock). The CI workflow resolves and installs CryptoStrategies from that stale project pin while overriding it to the new QPK API, so contract tests and runtime execute an unvalidated mixed bundle instead of the paired strategy catalog.

Useful? React with 👍 / 👎.

crypto_strategies = "ef78312d7653095f585c4f75d45bf765bedc2751"

[qsl.compat]
Expand Down
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading