Improve Firstrade small-account execution notices - #122
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3190f0ec95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| format_small_account_whole_share_bootstrap_notes( | ||
| allocation.get("small_account_whole_share_bootstrap_symbols") or (), | ||
| translator=translator, |
There was a problem hiding this comment.
Propagate bootstrap notes to run notifications
When the new bootstrap path fires during run_strategy_cycle (e.g., a zero-share SOXL/TQQQ/SOXX target is lifted to one limit-priced share), the symbol is written only into the adjusted plan local to execute_value_target_plan; the result that is passed to render_cycle_summary still uses the original plan.get("allocation", {}) in application/rebalance_service.py, and ExecutionCycleResult only carries cash-substitution notes. As a result, this formatter sees no small_account_whole_share_bootstrap_symbols in real cycle notifications, so the explicit buy note added here is only shown in tests that manually inject the allocation key.
Useful? React with 👍 / 👎.
Summary
Validation
Note: full platform tests were not run on this VPS because the active Python env lacks pandas/numpy/pytest.