Skip to content

Improve Firstrade small-account execution notices - #122

Merged
Pigbibi merged 2 commits into
mainfrom
codex/plugin-consumption-small-account-execution
Jun 23, 2026
Merged

Improve Firstrade small-account execution notices#122
Pigbibi merged 2 commits into
mainfrom
codex/plugin-consumption-small-account-execution

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add plugin consumption i18n fallback strings
  • support near-one-share small-account bootstrap for core symbols
  • render explicit buy notes when whole-share compatibility lifts a target to one share

Validation

  • git diff --name-only -- '*.py' | xargs -r python -m py_compile
  • Firstrade render_cycle_summary bootstrap note sample
  • i18n zh/en key, placeholder, and English CJK scans

Note: full platform tests were not run on this VPS because the active Python env lacks pandas/numpy/pytest.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3190f0ec95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
Comment on lines +1147 to +1149
format_small_account_whole_share_bootstrap_notes(
allocation.get("small_account_whole_share_bootstrap_symbols") or (),
translator=translator,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Propagate bootstrap notes to run notifications

When the new bootstrap path fires during run_strategy_cycle (e.g., a zero-share SOXL/TQQQ/SOXX target is lifted to one limit-priced share), the symbol is written only into the adjusted plan local to execute_value_target_plan; the result that is passed to render_cycle_summary still uses the original plan.get("allocation", {}) in application/rebalance_service.py, and ExecutionCycleResult only carries cash-substitution notes. As a result, this formatter sees no small_account_whole_share_bootstrap_symbols in real cycle notifications, so the explicit buy note added here is only shown in tests that manually inject the allocation key.

Useful? React with 👍 / 👎.

@Pigbibi
Pigbibi merged commit 3f0d0db into main Jun 23, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/plugin-consumption-small-account-execution branch June 23, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant