-
Notifications
You must be signed in to change notification settings - Fork 1
[codex] Prevent Telegram market symbol auto-links #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
|
|
||
| ROOT = Path(__file__).resolve().parents[1] | ||
| if str(ROOT) not in sys.path: | ||
| sys.path.insert(0, str(ROOT)) | ||
| PLATFORM_KIT_SRC = ROOT.parent / "QuantPlatformKit" / "src" | ||
| if str(PLATFORM_KIT_SRC) not in sys.path: | ||
| sys.path.insert(0, str(PLATFORM_KIT_SRC)) | ||
|
|
||
| from notifications.telegram import build_sender | ||
|
|
||
|
|
||
| class FakeRequests: | ||
| def __init__(self): | ||
| self.calls = [] | ||
|
|
||
| def post(self, url, json, timeout): | ||
| self.calls.append((url, json, timeout)) | ||
| return object() | ||
|
|
||
|
|
||
| def test_build_sender_breaks_market_symbol_auto_links(): | ||
| fake_requests = FakeRequests() | ||
| sender = build_sender("token-1", "chat-1", requests_module=fake_requests) | ||
| sender("SOXL.US and 00700.HK") | ||
|
|
||
| assert len(fake_requests.calls) == 1 | ||
| url, payload, timeout = fake_requests.calls[0] | ||
| assert "token-1" in url | ||
| assert payload["chat_id"] == "chat-1" | ||
| assert payload["text"] == "SOXL.\u2060US and 00700.\u2060HK" | ||
| assert timeout == 15 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a Telegram message contains an uppercase URL or domain such as
https://SOXL.US/reportorhttps://EXAMPLE.COM, this regex still matches the hostname/path segment and_break_telegram_market_symbol_auto_linksinserts\u2060into the URL. That changes the actual link target and can make real links in arbitrary sender messages unusable, even though only standalone market symbols should be altered.Useful? React with 👍 / 👎.