Skip to content

Fix strategy_registry sys.modules pollution in tests #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 27, 2026
Merged

Fix strategy_registry sys.modules pollution in tests #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions tests/test_runtime_execution_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,14 @@
_fake_registry = types.ModuleType("strategy_registry")
_fake_registry.PLATFORM_CAPABILITY_MATRIX = _FIRSTRADE_CAPABILITY_MATRIX
_fake_registry.STRATEGY_CATALOG = _FAKE_CATALOG
sys.modules["strategy_registry"] = _fake_registry

runtime_execution_policy = importlib.import_module("runtime_execution_policy")
runtime_execution_policy = importlib.reload(runtime_execution_policy)
notional_buy_execution_enabled = runtime_execution_policy.notional_buy_execution_enabled

@pytest.fixture
def notional_buy_fn(monkeypatch: pytest.MonkeyPatch):
monkeypatch.setitem(sys.modules, "strategy_registry", _fake_registry)
rep = importlib.import_module("runtime_execution_policy")
rep = importlib.reload(rep)
return rep.notional_buy_execution_enabled


@pytest.mark.parametrize(
Expand Down Expand Up @@ -119,7 +122,7 @@ def test_dca_profiles_require_fractional_share_capability() -> None:
assert FRACTIONAL_SHARE_EXECUTION_CAPABILITY in definition.compatible_capabilities


def test_firstrade_capability_matrix_allows_dca_profiles() -> None:
def test_firstrade_capability_matrix_allows_dca_profiles(notional_buy_fn) -> None:
for profile in ("nasdaq_sp500_smart_dca", "ibit_smart_dca"):
assert (
fractional_share_execution_unsupported_reason(
Expand All @@ -129,9 +132,9 @@ def test_firstrade_capability_matrix_allows_dca_profiles() -> None:
)
is None
)
assert notional_buy_execution_enabled(profile) is True
assert notional_buy_fn(profile) is True


def test_notional_buy_execution_disabled_for_non_dca_profiles() -> None:
assert notional_buy_execution_enabled("global_etf_rotation") is False
assert notional_buy_execution_enabled("tqqq_growth_income") is False
def test_notional_buy_execution_disabled_for_non_dca_profiles(notional_buy_fn) -> None:
assert notional_buy_fn("global_etf_rotation") is False
assert notional_buy_fn("tqqq_growth_income") is False
Loading