Skip to content

fix(ci): minimize Codex review privileges #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 10, 2026
Merged

fix(ci): minimize Codex review privileges #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/codex_pr_review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:
allow_unconfigured_backend: false
api_fallback_enabled: "false"
direct_api_primary_enabled: "false"
secrets: inherit
secrets:
CODEX_AUDIT_SERVICE_URL: ${{ secrets.CODEX_AUDIT_SERVICE_URL }}
permissions:
contents: read
id-token: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codex_review_gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions:
pull-requests: read

concurrency:
group: codex-review-gate-${{ github.event.pull_request.number }}
group: codex-review-gate-${{ github.event.pull_request.number }}-${{ github.event_name }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep stale WAIT checks from outliving review checks

Splitting the concurrency group by event lets the pull_request WAIT run and the pull_request_review REACT run for the same PR continue concurrently while both publish the same Codex Review Gate / gate check. If Codex submits CHANGES_REQUESTED, the REACT path fails immediately from the event payload, but the older WAIT path still ignores RuntimeError from get_codex_review and returns success on timeout (scripts/gate_codex_app_review.py:312-325); during a transient GitHub reviews API failure, that later green WAIT result can supersede the failing review gate. Keep runs that report the same gate in one concurrency group, or otherwise prevent the WAIT path from passing after a bot review event has fired.

Useful? React with 👍 / 👎.

cancel-in-progress: true

jobs:
Expand Down
Loading