Skip to content

Guard explicit IBKR target creation#193

Merged
Pigbibi merged 3 commits into
mainfrom
codex/guard-ibkr-target-creation
Jul 22, 2026
Merged

Guard explicit IBKR target creation#193
Pigbibi merged 3 commits into
mainfrom
codex/guard-ibkr-target-creation

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make the default IBKR switch mode update existing service targets only
  • require an explicit allow_create mode before appending a target
  • document and test the fail-closed behavior

Verification

  • python3 -m pytest -q python/tests/test_runtime_settings.py
  • workflow YAML parse
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: No issues found


Review by Codex PR Review bot • PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12ca8378bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/manual-strategy-switch.yml
@Pigbibi
Pigbibi enabled auto-merge (squash) July 22, 2026 02:54
Pigbibi and others added 2 commits July 22, 2026 10:57
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit b53b0bd into main Jul 22, 2026
8 checks passed
@Pigbibi
Pigbibi deleted the codex/guard-ibkr-target-creation branch July 22, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant