Skip to content

fix: reconcile dependency matrix baseline #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Aug 1, 2026
Merged

fix: reconcile dependency matrix baseline #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal_dependency_matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@
"path": "pyproject.toml",
"package": "quant-platform-kit",
"source_repo": "QuantPlatformKit",
"ref": "ff09c889ed21e2eb6fcb37f6cdaa159190ec82da"
"ref": "8ba8276948ff71a8cc0a810f98b7437a1311c671"
},
{
"consumer_repo": "UsEquitySnapshotPipelines",
Expand All @@ -314,14 +314,14 @@
"path": "pyproject.toml",
"package": "us-equity-strategies",
"source_repo": "UsEquityStrategies",
"ref": "b0b590ce5ac0233a40b8fb957c249cf375a6ff21"
"ref": "337f66bab1f88a7c4181d65ce8598ab182d2396c"
},
{
"consumer_repo": "UsEquitySnapshotPipelines",
"path": "uv.lock",
"package": "quant-platform-kit",
"source_repo": "QuantPlatformKit",
"ref": "ff09c889ed21e2eb6fcb37f6cdaa159190ec82da"
"ref": "8ba8276948ff71a8cc0a810f98b7437a1311c671"
},
{
"consumer_repo": "UsEquitySnapshotPipelines",
Expand All @@ -335,21 +335,21 @@
"path": "uv.lock",
"package": "us-equity-strategies",
"source_repo": "UsEquityStrategies",
"ref": "b0b590ce5ac0233a40b8fb957c249cf375a6ff21"
"ref": "337f66bab1f88a7c4181d65ce8598ab182d2396c"
},
{
"consumer_repo": "UsEquityStrategies",
"path": "pyproject.toml",
"package": "quant-platform-kit",
"source_repo": "QuantPlatformKit",
"ref": "92458590a463e7219f0369a3505031ee74414135"
"ref": "8ba8276948ff71a8cc0a810f98b7437a1311c671"
},
{
"consumer_repo": "UsEquityStrategies",
"path": "uv.lock",
"package": "quant-platform-kit",
"source_repo": "QuantPlatformKit",
"ref": "92458590a463e7219f0369a3505031ee74414135"
"ref": "8ba8276948ff71a8cc0a810f98b7437a1311c671"
}
]
}
33 changes: 18 additions & 15 deletions python/tests/test_internal_dependency_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,28 +99,31 @@ def test_current_matrix_matches_local_workspace(self):
self.assertEqual(report.missing_files, [])
self.assertEqual(report.issues, [])

def test_qpk_migrated_consumers_use_current_canonical_pin(self):
canonical_pin = "92458590a463e7219f0369a3505031ee74414135"
migrated_consumers = {
"BinancePlatform",
"CharlesSchwabPlatform",
"CnEquityStrategies",
"CryptoStrategies",
"FirstradePlatform",
"HkEquityStrategies",
"InteractiveBrokersPlatform",
"LongBridgePlatform",
"UsEquityStrategies",
def test_qpk_migrated_consumers_use_current_baseline_pins(self):
expected_pins_by_consumer = {
"BinancePlatform": "92458590a463e7219f0369a3505031ee74414135",
"CharlesSchwabPlatform": "92458590a463e7219f0369a3505031ee74414135",
"CnEquityStrategies": "92458590a463e7219f0369a3505031ee74414135",
"CryptoStrategies": "92458590a463e7219f0369a3505031ee74414135",
"FirstradePlatform": "92458590a463e7219f0369a3505031ee74414135",
"HkEquityStrategies": "92458590a463e7219f0369a3505031ee74414135",
"InteractiveBrokersPlatform": "92458590a463e7219f0369a3505031ee74414135",
"LongBridgePlatform": "92458590a463e7219f0369a3505031ee74414135",
"UsEquityStrategies": "8ba8276948ff71a8cc0a810f98b7437a1311c671",
}
matrix_pins = check_internal_dependency_matrix.load_matrix(ROOT / "internal_dependency_matrix.json")
refs = {
(pin.consumer_repo, pin.path): pin.ref
for pin in matrix_pins
if pin.consumer_repo in migrated_consumers and pin.source_repo == "QuantPlatformKit"
if pin.consumer_repo in expected_pins_by_consumer and pin.source_repo == "QuantPlatformKit"
}
expected_refs = {
(consumer_repo, path): ref
for consumer_repo, ref in expected_pins_by_consumer.items()
for path in ("pyproject.toml", "uv.lock")
}

self.assertEqual(len(refs), len(migrated_consumers) * 2)
self.assertEqual(set(refs.values()), {canonical_pin})
self.assertEqual(refs, expected_refs)

def test_require_consumer_files_treats_missing_paths_as_issues(self):
projects_root = self._make_projects_root({})
Expand Down