Skip to content

fix dismiss all Dependabot review requests#47

Merged
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-all-dependabot-review-requests
Jul 20, 2026
Merged

fix dismiss all Dependabot review requests#47
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-all-dependabot-review-requests

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Policy

Automatically generated Pigbibi review requests are dismissed only when the request event itself was created by Dependabot. Requests made by maintainers are preserved. Major dependency updates remain open because the existing auto-merge workflow excludes semver-major updates.

What changed

  • support dependabot[bot] and app/dependabot PR authors and event actors
  • react directly to review_requested events
  • serialize per-PR cleanup runs without cancelling the matching event
  • verify the latest paginated timeline request still came from Dependabot immediately before deletion
  • keep API failures visible while treating an already-removed request as success
  • do not checkout or execute PR code

Validation

  • bash syntax check
  • git diff --check

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Reliability in .github/workflows/dependabot_review_request_cleanup.yml

The workflow now decides whether to delete the review request from a single snapshot of the timeline and then unconditionally issues the DELETE, but the previous post-delete reconciliation logic was removed. If a human re-requests Pigbibi after latest_request_actor is computed but before the DELETE call completes, that manual request is still removed by this job. This race is reachable because review requests are a public PR action and the job no longer restores concurrent human intent. (line 66)

Suggestion: Reintroduce a concurrency-safe check after the DELETE, or perform a second timeline/current-reviewer read immediately before or after deletion and restore the request when a non-Dependabot actor re-requested it during the job run.


Review by Codex PR Review bot • PR

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the agent/dismiss-all-dependabot-review-requests branch from 61bf6be to a8f7e1f Compare July 20, 2026 06:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8f7e1ff46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/dependabot_review_request_cleanup.yml
@Pigbibi
Pigbibi merged commit ab1b441 into main Jul 20, 2026
5 checks passed
@Pigbibi
Pigbibi deleted the agent/dismiss-all-dependabot-review-requests branch July 20, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant