Skip to content

feat: add SOXL volatility scaling research overlay#288

Merged
Pigbibi merged 2 commits into
mainfrom
codex/t4s3-soxl-volatility-scaling-overlay-v1-20260723
Jul 23, 2026
Merged

feat: add SOXL volatility scaling research overlay#288
Pigbibi merged 2 commits into
mainfrom
codex/t4s3-soxl-volatility-scaling-overlay-v1-20260723

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • publication-only replacement for closed PR feat: add SOXL volatility scaling research overlay #287 after a PR-object/ref-binding anomaly
  • publish the existing same-repo branch at exact commit 2f7693c1e3b5b5424fca1c2bb6f32d756c755eb9
  • no code edit, amend, recommit, force-push, new branch, or new worktree was performed for this recovery

Recorded validation evidence

  • focused starting-peak regression: 1 passed
  • focused SOXL/R3 suite: 19 passed
  • compileall: passed
  • exact two-file scope and diff-check: passed
  • Ruff unavailable in the existing environment; no install performed

Research-only; no provider/data/optimization run or live adoption.

Pigbibi and others added 2 commits July 23, 2026 16:01
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f7693c1e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/us_equity_strategies/research/soxl_core_optimization.py
Comment thread src/us_equity_strategies/research/soxl_core_optimization.py
@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Logic in src/us_equity_strategies/research/soxl_core_optimization.py

The partial-sell rebalance path computes traded_quantity from the raw notional gap divided only by execution.open, then subtracts slippage and commission afterward. In run_soxl_volatility_scaling, every non-zero-cost scenario (C1_2, C2_5, C5_10_STRESS) uses this simulator, so whenever the SMA signal stays risk-on but the volatility multiplier decreases without going to zero, the remaining position ends up larger than the requested multiplier because post-trade equity is reduced by costs. That biases the candidate's return, drawdown, expected-shortfall, and turnover metrics, and can change winner selection or evidence gates. (line 250)

Suggestion: Solve the sell size against post-cost equity instead of the raw open price gap. For example, derive traded_quantity so that the remaining open notional matches the target after accounting for slippage and commission, or recompute the target from post-trade equity and iterate until the exposure ratio is within a small tolerance.


Review by Codex PR Review bot • PR

@Pigbibi
Pigbibi merged commit 6d0c998 into main Jul 23, 2026
10 checks passed
@Pigbibi
Pigbibi deleted the codex/t4s3-soxl-volatility-scaling-overlay-v1-20260723 branch July 23, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant