Skip to content

Instantiate broadcast for pullbacks #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 3 commits into from
Aug 11, 2026
+3 −3
Merged

Instantiate broadcast for pullbacks #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca7817
Instantiate broadcast for SVD pullback
kshyatt Aug 11, 2026
79e1528
Fix broadcast handling in eig pullback too
kshyatt Aug 11, 2026
faf4b7c
And eigh
kshyatt Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pullbacks/eig.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function check_and_prepare_eig_cotangents(
bc = Base.broadcasted(transpose(D), D, VᴴΔV₁) do d₁, d₂, v
return abs(d₁ - d₂) < degeneracy_atol ? v : zero(v)
end
Δgauge = maximum(abs, bc; init = abs(zero(eltype(D))))
Δgauge = maximum(abs, Base.Broadcast.instantiate(bc); init = abs(zero(eltype(D))))

Δgauge ≤ gauge_atol ||
@warn "`eig` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
Expand Down
2 changes: 1 addition & 1 deletion src/pullbacks/eigh.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function check_and_prepare_eigh_cotangents(
bc = Base.broadcasted(transpose(D), D, aVᴴΔV₁) do d₁, d₂, v
return abs(d₁ - d₂) < degeneracy_atol ? v : zero(v)
end
Δgauge = maximum(abs, bc; init = abs(zero(eltype(D))))
Δgauge = maximum(abs, Base.Broadcast.instantiate(bc); init = abs(zero(eltype(D))))

Δgauge ≤ gauge_atol ||
@warn "`eigh` cotangents sensitive to gauge choice: (|Δgauge| = $Δgauge)"
Expand Down
2 changes: 1 addition & 1 deletion src/pullbacks/svd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function check_and_prepare_svd_cotangents(
bc = Base.broadcasted(S₁', S₁, aUᴴΔU₁, aVᴴΔV₁) do s₁, s₂, u, v
return abs(s₁ - s₂) < degeneracy_atol ? u + v : zero(u) + zero(v)
end
Δgauge = max(Δgauge, maximum(abs, bc))
Δgauge = max(Δgauge, maximum(abs, Base.Broadcast.instantiate(bc)))

if !iszerotangent(ΔSmat)
ΔS = diagview(ΔSmat)
Expand Down
Loading