Conversation
lkdvos
reviewed
Aug 7, 2026
| using FiniteDifferences | ||
|
|
||
| function FiniteDifferences.to_vec(x::StridedView) | ||
| x_vec, from_vec = FiniteDifferences.to_vec(Array(x)) |
Member
There was a problem hiding this comment.
do you know if this is an extra copy we might be able to avoid?
Member
Author
There was a problem hiding this comment.
I tried it (removing the Array) back at TensorKit and the tests all started blowing up again, unfortunately
lkdvos
reviewed
Aug 7, 2026
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for QuantumKitHub/TensorKit.jl#493 and I want to avoid type piracy there :). FD doesn't know how to read StridedViews correctly on its own, which is why the ChainRules tests were failing over there.