Conversation
|
As you can tell in the braidingtensor implementation, I was actually making use of the fact that you only need distinct levels for legs that will actually cross. This might actually be a useful feature at some point, since in principle we could envision designing an ITensor-like system that holds on to space,level and and id, and at that point it might be annoying to ensure uniqueness. As an alternative, how about within the actual braiding code where we check which level is larger we add a check that they are not equal whenever the braiding is not symmetric? |
levels in braidlevels in anyonic braid
|
The only downsides here are that the error will be raised much deeper, and that you can do bad homspace braids, but I can live with that :) |
lkdvos
left a comment
There was a problem hiding this comment.
So reading this in a bit more detail, I think the goal has always been to have levels refer to a height, so larger values braid over lower values, and I guess the implementation was wrong (I'm also not entirely sure if we have anything that can test this, as of course this is just the same as using the timereversed category)
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This is in contrast with the one example in the docs, where level = depth (it's mentioned literally in the text below the image). So that's why I changed everything to be consistent with depth. The current implemenation checks |
|
Well, in that case maybe it's just my brain that always translated it to heights. Good catch, in that case I absolutely agree the language should become depths ;) |
lkdvos
left a comment
There was a problem hiding this comment.
Left some minor comments about wording, otherwise good to go for me!
Previously, equal
levelswere allowed to be passed tobraid, which would then silently overbraid. The docstring was not clear about this being allowed, so I changed some things to just simply forbid it. There were also some inconsistencies in docs/docstrings on how to interpret levels, so now I put "depths" everywhere as the synonym to them.