chore: regenerate pallet weights - #650
Merged
Merged
Conversation
- Regenerate weights for all benchmarked pallets: wormhole, multisig, reversible-transfers, scheduler, mining-rewards, treasury, vesting, balances, frame-system - Fix wormhole benchmark fixtures: regenerate proofs at the production 4 bps volume fee (stale 10 bps fixtures made the pre_validate benchmarks panic against the live runtime); align mock fee rate - Extend regenerate_weights.sh with pallet_balances and frame_system, and document the hand-augmented weight files that raw regeneration must not overwrite
illuzen
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates benchmark weights for every pallet registered in
define_benchmarkswhose weights the runtime actually consumes, measured on currentmain(includes #646 vesting).What changed
Regenerated weights (50 steps / 20 repeats, compiled WASM): wormhole, multisig, reversible-transfers, scheduler, mining-rewards, treasury, vesting — plus balances and frame-system, which were registered and wired into the runtime but missing from the script.
regenerate_weights.shnow covers them.Fixed broken wormhole benchmarks —
pre_validate_proof/pre_validate_public_batch_proofpanicked against the live runtime: the committed proof fixtures (test-data/*.hex) still baked in the old 10 bps volume fee, while the runtime has charged 4 bps since #632, so production pre-validation rejected the fixture withInvalidVolumeFeeRate. Mock-based tests never caught it because the mock was pinned to 10 bps to match the fixtures. Fixtures regenerated at 4 bps; mock and affected tests aligned.Hand-augmented weight files preserved — a raw template run wipes these, so the measured bases were merged into the existing hand layers instead:
wormhole: refreshed the four timing constants. Notable moves: public-batch pre-validation 4.5B → 1.9B ps (cheaper production path after turnstile removal in Remove wormhole turnstile (soundness counters and address reveal) #645), private pre-validation 700M → 900M ps, ZK verify 14.97B → 15.16B / 20.69B → 21.08B ps. Depth-scaling storage tails and invariant tests kept; the public pre-validation floor test now tracks the post-Remove wormhole turnstile (soundness counters and address reveal) #645 cost.mining-rewards: measured base 163M → 162M ps; depth pricing and tests kept.reversible-transfers:execute_transferbase 110M → 98M ps; live-depth pricing helper and tests kept, other extrinsics take fresh measurements.scheduler: kept the V12 audit #162534 explicitRetrieswrite charge inservice_task_base(benchmark still doesn't measure it).regenerate_weights.shdocuments these hand layers so future runs don't silently drop them.Verification
cargo check --workspace --releaseclean