-
Notifications
You must be signed in to change notification settings - Fork 7
Illuzen/gpu bench #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
illuzen
wants to merge
14
commits into
main
Choose a base branch
from
illuzen/gpu-bench
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
83dae99
gpu bench
illuzen 008e7f8
setup script
illuzen 38da9e4
updated gpu-bench/README.md
Jfangle fcfa887
fix gpu-bench: nvidia-smi sm-count fallback and node-key path capture
Jfangle 21de287
Add RunPod GPU bench sweep with Vulkan-ready remote runner.
illuzen 38186df
Track gpu-bench results.csv as a collaborative hardware dataset.
illuzen 2bb4d0e
Improve GPU tier matching and build miner from git in gpu-bench.
illuzen 90558dc
Merge origin/illuzen/gpu-bench into illuzen/gpu-bench.
illuzen a1434d8
Fix Vulkan setup when apt GL packages mismatch the host driver.
illuzen 74ae659
banner brokens
illuzen 7bfd6a8
pass thru batch sizes
illuzen 4db7e86
better benchmarks
illuzen 0ed276c
collect results
illuzen edb8aa1
more realistic benchmark
illuzen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consumer GPU tiers miss entry SKUs
Medium Severity
Removing the bare
rtx 50/rtx 40/rtx 20catch-alls without widening the digit classes leaves real GeForce entry SKUs unmatched (RTX 5050,RTX 4050,RTX 2050), so they fall through to the NVIDIA unknown fallback. That breaks the GPU tier pattern rule requiring most-specific-first ordering and no coverage gaps when patterns change.Additional Locations (2)
crates/engine-gpu/src/gpu_tiers.rs#L213-L216crates/engine-gpu/src/gpu_tiers.rs#L220-L222Triggered by learned rule: GPU tier patterns: check ordering and overlap
Reviewed by Cursor Bugbot for commit 7bfd6a8. Configure here.