fix: Python 3.13 compatibility fixes for C extension#1
Open
ping-ke wants to merge 1 commit into
Open
Conversation
ping-ke
commented
May 9, 2026
ping-ke
commented
- Replace distutils with setuptools in setup.py
- Remove alloca.h include (not needed, causes issues on some platforms)
- Use Py_ssize_t for size parameters to match Python 3 API
- Cast string/buffer args to const char * for Py_BuildValue
- Fix memory leaks: use ethash_light_delete instead of free(L->cache), free s and h structs after ethash_light_compute
- Add NULL check for PyModule_Create return value
- Replace distutils with setuptools in setup.py - Remove alloca.h include (not needed, causes issues on some platforms) - Use Py_ssize_t for size parameters to match Python 3 API - Cast string/buffer args to const char * for Py_BuildValue - Fix memory leaks: use ethash_light_delete instead of free(L->cache), free s and h structs after ethash_light_compute - Add NULL check for PyModule_Create return value
ping-ke
requested review from
blockchaindevsh,
iteyelmp,
qizhou,
qzhodl and
syntrust
| PyObject * val = Py_BuildValue(PY_STRING_FORMAT, L->cache, L->cache_size); | ||
| free(L->cache); | ||
| PyObject * val = Py_BuildValue(PY_STRING_FORMAT, L->cache, (Py_ssize_t)L->cache_size); | ||
| ethash_light_delete(L); |
There was a problem hiding this comment.
So the old version always leaks memory?
blockchaindevsh
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.